Fix dropdown menu keyboard navigation #147285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
PurplePolyhedron
changed the title
bleroux
reviewed
Apr 24, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I spotted some minor indentation issues.
cc @QuncCccccc who has a great knowledge of this widget.
bleroux
reviewed
Apr 24, 2024
Co-authored-by: Bruno Leroux <[email protected]>
This reverts commit a965deb.
Contributor
Author
|
I didn't know using the "add suggestion to batch" on Github would break the CLA check. Do I need to close this PR and create a new one? |
9 tasks
Contributor
Author
|
I will close this PR and move to #147294 because CLA breaks are difficult to fix |
auto-submit bot
pushed a commit
that referenced
this pull request
May 10, 2024
Fix #147253 Fix #147516 Resubmitted #147285 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and I cannot revert it. I use exact match of label instead of contains to minimise possible change in actual user search. I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR. Let me know if I need to make any changes. Sorry for the inconvenience, I am new to the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #147253
I use exact match of label instead of
containsto minimise possible change in actual user search.I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR.
Let me know if I need to make any changes.
Move to #147294 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and it cannot be reverted.
Pre-launch Checklist
///).