Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked #147271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
Hixie
force-pushed
the
silver_tests_prep
branch
from
f0358f2 to
770b89f
Compare
…rom the rendering layer to be hooked This also includes some minor cleanup of documentation, asserts, and tests.
Hixie
force-pushed
the
silver_tests_prep
branch
from
770b89f to
b970e3f
Compare
goderbauer
approved these changes
Apr 24, 2024
Member
There was a problem hiding this comment.
Should we annotated these with @factory to enforce the "create" bit?
Contributor
Author
There was a problem hiding this comment.
I don't feel very strongly about this. It's an API that few people will ever use, and those who use it will presumably want to use correctly, or will have very good reasons for doing weird things with it. If you would like me to annotate it though, let me know. :-)
Member
There was a problem hiding this comment.
No strong feelings on this one either way.
Member
There was a problem hiding this comment.
Maybe also update the dart:ui documentation on SceneBuilder, Canvas, and PictureRecorder to at least cross-link to the create* methods on RenderBinding? If I need to create any of those objects I would look there first and probably totally miss that I should be going through the bindings.
Contributor
Author
|
@goderbauer Can you check the reason for the Google testing failure? |
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Apr 24, 2024
See flutter/flutter#147271 for context. Do not land until flutter/flutter#147271 has landed.
Member
Looking... |
Member
There's an infra failure. I checked with the infra team and they say we have some ongoing quota issues. Infra team is advising to wait a little (maybe even until tomorrow if you can), then rebasing the PR to trigger the check again. |
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Apr 24, 2024
See flutter/flutter#147271 for context. Do not land until flutter/flutter#147271 has landed.
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Apr 25, 2024
…vas (#52374) See flutter/flutter#147271 for context. Do not land until flutter/flutter#147271 has landed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 25, 2024
… calls from the rendering layer to be hooked (flutter/flutter#147271)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 25, 2024
flutter/flutter@dba4f77...5d3bca4 2024-04-25 [email protected] Roll Flutter Engine from 6b33890a4701 to 674890ce7141 (1 revision) (flutter/flutter#147365) 2024-04-25 [email protected] [native_assets] Use kernel concatenation (flutter/flutter#147158) 2024-04-25 [email protected] Roll Flutter Engine from ccd57f5a4bc4 to 6b33890a4701 (2 revisions) (flutter/flutter#147359) 2024-04-25 [email protected] Roll Flutter Engine from 9de649ed2926 to ccd57f5a4bc4 (1 revision) (flutter/flutter#147356) 2024-04-25 [email protected] Roll Flutter Engine from 2f48456a425a to 9de649ed2926 (2 revisions) (flutter/flutter#147354) 2024-04-25 [email protected] Roll Flutter Engine from f48f3b6a0172 to 2f48456a425a (1 revision) (flutter/flutter#147351) 2024-04-25 [email protected] Roll Flutter Engine from b30c0a765680 to f48f3b6a0172 (8 revisions) (flutter/flutter#147348) 2024-04-25 [email protected] Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked (flutter/flutter#147271) 2024-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/flutter#147334) 2024-04-24 [email protected] Fix filled color is wrong for a focused and hovered TextField (flutter/flutter#146976) 2024-04-24 [email protected] Roll Flutter Engine from b5d5832f7144 to b30c0a765680 (14 revisions) (flutter/flutter#147336) 2024-04-24 [email protected] Run new_gallery__transition_perf on mokey in staging (flutter/flutter#147339) 2024-04-24 [email protected] Remove hidden dependencies on the default goldenFileComparator. (flutter/flutter#146956) 2024-04-24 [email protected] Add create app and plugin templates for Swift Package Manager (flutter/flutter#147082) 2024-04-24 [email protected] Add support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle` (flutter/flutter#147103) 2024-04-24 [email protected] Mark firebase tests as `bringup: true` (flutter/flutter#147338) 2024-04-24 [email protected] Add Valentin Vignal to AUTHORS (flutter/flutter#147314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@dba4f77...5d3bca4 2024-04-25 [email protected] Roll Flutter Engine from 6b33890a4701 to 674890ce7141 (1 revision) (flutter/flutter#147365) 2024-04-25 [email protected] [native_assets] Use kernel concatenation (flutter/flutter#147158) 2024-04-25 [email protected] Roll Flutter Engine from ccd57f5a4bc4 to 6b33890a4701 (2 revisions) (flutter/flutter#147359) 2024-04-25 [email protected] Roll Flutter Engine from 9de649ed2926 to ccd57f5a4bc4 (1 revision) (flutter/flutter#147356) 2024-04-25 [email protected] Roll Flutter Engine from 2f48456a425a to 9de649ed2926 (2 revisions) (flutter/flutter#147354) 2024-04-25 [email protected] Roll Flutter Engine from f48f3b6a0172 to 2f48456a425a (1 revision) (flutter/flutter#147351) 2024-04-25 [email protected] Roll Flutter Engine from b30c0a765680 to f48f3b6a0172 (8 revisions) (flutter/flutter#147348) 2024-04-25 [email protected] Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked (flutter/flutter#147271) 2024-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/flutter#147334) 2024-04-24 [email protected] Fix filled color is wrong for a focused and hovered TextField (flutter/flutter#146976) 2024-04-24 [email protected] Roll Flutter Engine from b5d5832f7144 to b30c0a765680 (14 revisions) (flutter/flutter#147336) 2024-04-24 [email protected] Run new_gallery__transition_perf on mokey in staging (flutter/flutter#147339) 2024-04-24 [email protected] Remove hidden dependencies on the default goldenFileComparator. (flutter/flutter#146956) 2024-04-24 [email protected] Add create app and plugin templates for Swift Package Manager (flutter/flutter#147082) 2024-04-24 [email protected] Add support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle` (flutter/flutter#147103) 2024-04-24 [email protected] Mark firebase tests as `bringup: true` (flutter/flutter#147338) 2024-04-24 [email protected] Add Valentin Vignal to AUTHORS (flutter/flutter#147314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
… calls from the rendering layer to be hooked (flutter/flutter#147271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some minor cleanup of documentation, asserts, and tests.