Fix frozen `StretchingOverscrollIndicator` animation #147195

gilnobrega · 2024-04-22T22:06:16Z

StretchingOverscrollIndicator's controller does not have a minimum value for its animation duration.
When the OverscrollNotification's velocity is small enough (< 25) the controller's absorbImpact method sets this animation duration to 0ms, making the animation appear frozen to the user.

This PR sets a minimum animation duration of 50ms.

Fixes #146277

Before	After
Screen.Recording.2024-04-04.at.16.07.43.mov	Screen.Recording.2024-04-04.at.16.34.17.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gilnobrega · 2024-04-22T22:14:56Z

packages/flutter/lib/src/widgets/overscroll_indicator.dart

+  // Constants for absorbImpact.
+  static const double _minVelocity = 1;
+  static const double _maxVelocity = 10000;
+  static const Duration _minStretchDuration = Duration(milliseconds: 50);
+


@Piinks Google testing step failed again so I thought I'd update the branch in #146280 with the latest master.

I managed to ruin the commit tree so I've opened this PR instead.

Please have a look at the constants introduced here as per the feedback left by @chunhtai

for const, you should start with _k

chunhtai

LGTM

Piinks

Ah sorry about the rebase issue, thanks for sticking with it! Much appreciated contribution, LGTM. :)

The Google testing shard will likely fail again, we'll just need to set it green when it does to land.

…/flutter#147195)

flutter/flutter@77043ba...dba4f77 2024-04-24 [email protected] Fix memory leaks in `BottomNavigationBar` (flutter/flutter#147213) 2024-04-24 [email protected] Disable leak tracking for selection text area (flutter/flutter#147273) 2024-04-24 [email protected] Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685) 2024-04-24 [email protected] Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293) 2024-04-24 [email protected] Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281) 2024-04-24 [email protected] Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276) 2024-04-24 [email protected] Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272) 2024-04-24 [email protected] Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270) 2024-04-24 [email protected] Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267) 2024-04-23 [email protected] Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266) 2024-04-23 [email protected] Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264) 2024-04-23 [email protected] Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843) 2024-04-23 [email protected] Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722) 2024-04-23 [email protected] Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962) 2024-04-23 [email protected] Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262) 2024-04-23 [email protected] Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258) 2024-04-23 [email protected] Add test for focus_node.0.dart API example. (flutter/flutter#146943) 2024-04-23 [email protected] Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255) 2024-04-23 [email protected] Refactor framework + test harness tests (flutter/flutter#146213) 2024-04-23 [email protected] Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509) 2024-04-23 [email protected] Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248) 2024-04-23 [email protected] Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195) 2024-04-23 [email protected] Add test for animated_align.0.dart API example. (flutter/flutter#146719) 2024-04-23 [email protected] Fix typos related to Navigator (flutter/flutter#147221) 2024-04-23 [email protected] Fix memory leak in switch painter (flutter/flutter#147228) 2024-04-23 [email protected] Add test for animated_positioned.0.dart API example. (flutter/flutter#146720) 2024-04-23 [email protected] Update icon tree shaker to allow system font fallback (flutter/flutter#147202) 2024-04-23 [email protected] `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293) 2024-04-23 [email protected] Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241) 2024-04-23 [email protected] Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…/flutter#147195)

reland fix and tests

990b80a

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Apr 22, 2024

gilnobrega changed the title ~~reland fix and tests~~ Fix frozen StretchingOverscrollIndicator animation Apr 22, 2024

gilnobrega commented Apr 22, 2024

View reviewed changes

rename constants

12e8a8e

gilnobrega requested a review from chunhtai April 23, 2024 11:45

chunhtai approved these changes Apr 23, 2024

View reviewed changes

chunhtai requested a review from Piinks April 23, 2024 16:41

Piinks approved these changes Apr 23, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2024

auto-submit bot merged commit dd647b0 into flutter:master Apr 23, 2024

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to fa85f69e47d8 (28 revisions) flutter/packages#6604

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

dd647b0 Fix frozen StretchingOverscrollIndicator animation (flutter…

a00d5e1

…/flutter#147195)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to 2676c84a90d2 (29 revisions) flutter/packages#6606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

dd647b0 Fix frozen StretchingOverscrollIndicator animation (flutter…

3e71608

…/flutter#147195)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) flutter/packages#6607

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

dd647b0 Fix frozen StretchingOverscrollIndicator animation (flutter…

263380c

…/flutter#147195)

HansMuller mentioned this pull request Apr 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

dd647b0 Fix frozen StretchingOverscrollIndicator animation (flutter…

17bd968

…/flutter#147195)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix frozen `StretchingOverscrollIndicator` animation #147195

Fix frozen `StretchingOverscrollIndicator` animation #147195

Uh oh!

gilnobrega commented Apr 22, 2024

Uh oh!

gilnobrega Apr 22, 2024

Uh oh!

chunhtai Apr 22, 2024

Uh oh!

chunhtai left a comment

Uh oh!

Piinks left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix frozen StretchingOverscrollIndicator animation #147195

Fix frozen StretchingOverscrollIndicator animation #147195

Uh oh!

Conversation

gilnobrega commented Apr 22, 2024

Pre-launch Checklist

Uh oh!

gilnobrega Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

chunhtai Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix frozen `StretchingOverscrollIndicator` animation #147195

Fix frozen `StretchingOverscrollIndicator` animation #147195