Skip to content

fixes some gesture not getting disposed #147112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
Apr 20, 2024
Merged

fixes some gesture not getting disposed #147112

polina-c merged 2 commits into from
Apr 20, 2024

Conversation

@Dimilkalathiya
Copy link
Contributor

@Dimilkalathiya Dimilkalathiya commented Apr 20, 2024

part of #141198

Fixes some gestures not getting disposed

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: gestures flutter/packages/flutter/gestures repository. labels Apr 20, 2024
@Dimilkalathiya
Copy link
Contributor Author

Dimilkalathiya commented Apr 20, 2024

cc: @polina-c found some gesture leaks while testing curve animation leaks

@Dimilkalathiya Dimilkalathiya changed the title some gesture not getting disposed fixes some gesture not getting disposed Apr 20, 2024
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 20, 2024
polina-c
polina-c approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@polina-c polina-c merged commit 158a9a8 into flutter:master Apr 20, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2024
@engine-flutter-autoroll
158a9a8 fixes some gesture not getting disposed (flutter/flutter#147112)
d90cd6f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2024
@engine-flutter-autoroll
158a9a8 fixes some gesture not getting disposed (flutter/flutter#147112)
b7a518b
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 21, 2024
@engine-flutter-autoroll
Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (#6583)
690eb30 
flutter/flutter@98685a0...1a905d5

2024-04-21 [email protected] Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136)
2024-04-21 [email protected] Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134)
2024-04-21 [email protected] Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128)
2024-04-21 [email protected] Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125)
2024-04-20 [email protected] fixes some gesture not getting disposed (flutter/flutter#147112)
2024-04-20 [email protected] Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114)
2024-04-20 [email protected] Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108)
2024-04-20 [email protected] Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105)
2024-04-20 [email protected] Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104)
2024-04-20 [email protected] Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101)
2024-04-20 [email protected] Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099)
2024-04-20 [email protected] Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095)
2024-04-19 [email protected] Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065)
2024-04-19 [email protected] Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091)
2024-04-19 [email protected] Roll pub packages (flutter/flutter#147030)
2024-04-19 [email protected] Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724)
2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090)
2024-04-19 [email protected] [material] Fix info text (flutter/flutter#147040)
2024-04-19 [email protected] Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088)
2024-04-19 [email protected] Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085)
2024-04-19 [email protected] Add test for animated_padding.0.dart API example. (flutter/flutter#146718)
2024-04-19 [email protected] Refactor android preview tool integration tests (flutter/flutter#146518)
2024-04-19 [email protected] Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083)
2024-04-19 [email protected] Add test for dismissible.0.dart API example. (flutter/flutter#146723)
2024-04-19 [email protected] Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079)
2024-04-19 [email protected] Update docs around ga3 ga4 mismatch (flutter/flutter#147075)
2024-04-19 [email protected] Add test for preferred_size.0.dart API example. (flutter/flutter#146725)
2024-04-19 [email protected] Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068)
2024-04-19 [email protected] Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061)
2024-04-19 [email protected] Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@Dimilkalathiya @gilnobrega
fixes some gesture not getting disposed (flutter#147112)
f015f99
@HansMuller HansMuller mentioned this pull request Apr 26, 2024
Closed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter#6583)
be8cfd9 
flutter/flutter@98685a0...1a905d5

2024-04-21 [email protected] Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (flutter/flutter#147136)
2024-04-21 [email protected] Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (flutter/flutter#147134)
2024-04-21 [email protected] Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (flutter/flutter#147128)
2024-04-21 [email protected] Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (flutter/flutter#147125)
2024-04-20 [email protected] fixes some gesture not getting disposed (flutter/flutter#147112)
2024-04-20 [email protected] Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (flutter/flutter#147114)
2024-04-20 [email protected] Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (flutter/flutter#147108)
2024-04-20 [email protected] Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (flutter/flutter#147105)
2024-04-20 [email protected] Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (flutter/flutter#147104)
2024-04-20 [email protected] Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (flutter/flutter#147101)
2024-04-20 [email protected] Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (flutter/flutter#147099)
2024-04-20 [email protected] Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (flutter/flutter#147095)
2024-04-19 [email protected] Add Kostiantyn Sokolovskyi to the AUTHORS. (flutter/flutter#147065)
2024-04-19 [email protected] Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (flutter/flutter#147091)
2024-04-19 [email protected] Roll pub packages (flutter/flutter#147030)
2024-04-19 [email protected] Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (flutter/flutter#146724)
2024-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/flutter#147090)
2024-04-19 [email protected] [material] Fix info text (flutter/flutter#147040)
2024-04-19 [email protected] Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (flutter/flutter#147088)
2024-04-19 [email protected] Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (flutter/flutter#147085)
2024-04-19 [email protected] Add test for animated_padding.0.dart API example. (flutter/flutter#146718)
2024-04-19 [email protected] Refactor android preview tool integration tests (flutter/flutter#146518)
2024-04-19 [email protected] Roll Flutter Engine from 1363b52813e3 to 5083af669cee (1 revision) (flutter/flutter#147083)
2024-04-19 [email protected] Add test for dismissible.0.dart API example. (flutter/flutter#146723)
2024-04-19 [email protected] Roll Flutter Engine from 908f619d9e1c to 1363b52813e3 (4 revisions) (flutter/flutter#147079)
2024-04-19 [email protected] Update docs around ga3 ga4 mismatch (flutter/flutter#147075)
2024-04-19 [email protected] Add test for preferred_size.0.dart API example. (flutter/flutter#146725)
2024-04-19 [email protected] Roll Flutter Engine from 9cc1cc3de1a7 to 908f619d9e1c (1 revision) (flutter/flutter#147068)
2024-04-19 [email protected] Roll Flutter Engine from 7fafbbf17c02 to 9cc1cc3de1a7 (1 revision) (flutter/flutter#147061)
2024-04-19 [email protected] Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter/flutter#147059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dimilkalathiya @polina-c