Fixed few typos #147087
Merged
Fixed few typos #147087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
goderbauer
approved these changes
Apr 19, 2024
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM after the two comments are resolved.
examples/api/test/material/dropdown_menu/dropdown_menu.2_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/swift_package_manager_test.dart
Outdated
Show resolved
Hide resolved
Renzo-Olivares
approved these changes
Apr 19, 2024
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM pending @goderbauer comments
Contributor
Author
All done! |
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 22, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 22, 2024
flutter/flutter@1a905d5...140edb9 2024-04-22 [email protected] Fixed few typos (flutter/flutter#147087) 2024-04-22 [email protected] Add Amir Panahandeh to AUTHORS (flutter/flutter#147052) 2024-04-22 [email protected] print traces when transforming an asset (flutter/flutter#146374) 2024-04-22 [email protected] Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (flutter/flutter#147164) 2024-04-22 [email protected] Reland "Expose build mode in environment of asset transformer processes" (flutter/flutter#144958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
Here's another PR with a couple of typos fixed. As you can see there was a typo in _fileReferenceI**n**dentifiers_, in class _ParsedProjectInfo._ Maybe we should do some check on that since I'm not sure if that property is used somewhere outside Flutter?
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@1a905d5...140edb9 2024-04-22 [email protected] Fixed few typos (flutter/flutter#147087) 2024-04-22 [email protected] Add Amir Panahandeh to AUTHORS (flutter/flutter#147052) 2024-04-22 [email protected] print traces when transforming an asset (flutter/flutter#146374) 2024-04-22 [email protected] Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (flutter/flutter#147164) 2024-04-22 [email protected] Reland "Expose build mode in environment of asset transformer processes" (flutter/flutter#144958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another PR with a couple of typos fixed. As you can see there was a typo in fileReferenceIndentifiers, in class ParsedProjectInfo. Maybe we should do some check on that since I'm not sure if that property is used somewhere outside Flutter?
Pre-launch Checklist
///).