Skip to content

Conversation

@Amir-P
Copy link
Contributor

@Amir-P Amir-P commented Apr 19, 2024

Reference: author:amir-p

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 19, 2024

auto label is removed for flutter/flutter/147052, due to Pull request flutter/flutter/147052 is not in a mergeable state.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024
@Amir-P Amir-P requested a review from goderbauer April 20, 2024 06:06
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2024
@auto-submit auto-submit bot merged commit d737b7b into flutter:master Apr 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2024
@Amir-P Amir-P deleted the add_amir_panahandeh_to_authors branch April 22, 2024 20:09
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 22, 2024
flutter/flutter@1a905d5...140edb9

2024-04-22 [email protected] Fixed few typos (flutter/flutter#147087)
2024-04-22 [email protected] Add Amir Panahandeh to AUTHORS (flutter/flutter#147052)
2024-04-22 [email protected] print traces when transforming an asset (flutter/flutter#146374)
2024-04-22 [email protected] Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (flutter/flutter#147164)
2024-04-22 [email protected] Reland "Expose build mode in environment of asset transformer processes" (flutter/flutter#144958)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@1a905d5...140edb9

2024-04-22 [email protected] Fixed few typos (flutter/flutter#147087)
2024-04-22 [email protected] Add Amir Panahandeh to AUTHORS (flutter/flutter#147052)
2024-04-22 [email protected] print traces when transforming an asset (flutter/flutter#146374)
2024-04-22 [email protected] Roll Packages from 88a3a56 to 01a32c4 (5 revisions) (flutter/flutter#147164)
2024-04-22 [email protected] Reland "Expose build mode in environment of asset transformer processes" (flutter/flutter#144958)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants