Skip to content

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented Apr 18, 2024

The flutterroot param is accessible from the util function after the recent refactor of utils #146592 so this change cleans up the references to the suite runners to make them simpler.

Part of #145482

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj self-assigned this Apr 18, 2024
@sealesj sealesj added the team-infra Owned by Infrastructure team label Apr 18, 2024
@sealesj sealesj changed the title Clean up flutterroot param Clean up flutteRroot param Apr 18, 2024
@sealesj sealesj changed the title Clean up flutteRroot param Clean up flutteRroot Apr 18, 2024
@sealesj sealesj changed the title Clean up flutteRroot Clean up flutterRoot Apr 18, 2024
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 18, 2024

auto label is removed for flutter/flutter/147010, Failed to merge flutter/flutter/147010 with Pull request flutter/flutter/147010 could not be merged: Pull Request is still a draft.

@sealesj sealesj marked this pull request as ready for review April 18, 2024 22:31
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024
@auto-submit auto-submit bot merged commit ece6ac2 into flutter:master Apr 18, 2024
@sealesj sealesj deleted the cleanup_runners branch April 18, 2024 22:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 19, 2024
flutter/flutter@fb110b9...98685a0

2024-04-19 [email protected] Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056)
2024-04-19 [email protected] Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046)
2024-04-19 [email protected] Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038)
2024-04-19 [email protected] Update link branches to `main` (continued) (flutter/flutter#146985)
2024-04-19 [email protected] Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035)
2024-04-19 [email protected] Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029)
2024-04-19 [email protected] Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025)
2024-04-19 [email protected] Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023)
2024-04-19 [email protected] Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453)
2024-04-19 [email protected] Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022)
2024-04-18 [email protected] Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017)
2024-04-18 [email protected] Add a breadcrumb for the pub autoroller (flutter/flutter#146786)
2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015)
2024-04-18 [email protected] Redundant message fix (flutter/flutter#143978)
2024-04-18 [email protected] Clean up flutterRoot (flutter/flutter#147010)
2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011)
2024-04-18 [email protected] Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256)
2024-04-18 [email protected] Refactor framework coverage tests (flutter/flutter#146210)
2024-04-18 [email protected] Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006)
2024-04-18 [email protected] Changing the renderer on the web target should change its build key. (flutter/flutter#147003)
2024-04-18 [email protected] Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005)
2024-04-18 [email protected] Add generic type for result in PopScope (flutter/flutter#139164)
2024-04-18 [email protected] Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002)
2024-04-18 [email protected] [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958)
2024-04-18 [email protected] Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996)
2024-04-18 [email protected] Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993)
2024-04-18 [email protected] Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992)
2024-04-18 [email protected] Fix memory leaks in navigation rail (flutter/flutter#146988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
The flutterroot param is accessible from the util function after the recent refactor of utils flutter#146592 so this change cleans up the references to the suite runners to make them simpler. 

Part of flutter#145482
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@fb110b9...98685a0

2024-04-19 [email protected] Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056)
2024-04-19 [email protected] Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046)
2024-04-19 [email protected] Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038)
2024-04-19 [email protected] Update link branches to `main` (continued) (flutter/flutter#146985)
2024-04-19 [email protected] Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035)
2024-04-19 [email protected] Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029)
2024-04-19 [email protected] Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025)
2024-04-19 [email protected] Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023)
2024-04-19 [email protected] Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453)
2024-04-19 [email protected] Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022)
2024-04-18 [email protected] Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017)
2024-04-18 [email protected] Add a breadcrumb for the pub autoroller (flutter/flutter#146786)
2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015)
2024-04-18 [email protected] Redundant message fix (flutter/flutter#143978)
2024-04-18 [email protected] Clean up flutterRoot (flutter/flutter#147010)
2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011)
2024-04-18 [email protected] Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256)
2024-04-18 [email protected] Refactor framework coverage tests (flutter/flutter#146210)
2024-04-18 [email protected] Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006)
2024-04-18 [email protected] Changing the renderer on the web target should change its build key. (flutter/flutter#147003)
2024-04-18 [email protected] Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005)
2024-04-18 [email protected] Add generic type for result in PopScope (flutter/flutter#139164)
2024-04-18 [email protected] Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002)
2024-04-18 [email protected] [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958)
2024-04-18 [email protected] Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996)
2024-04-18 [email protected] Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993)
2024-04-18 [email protected] Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992)
2024-04-18 [email protected] Fix memory leaks in navigation rail (flutter/flutter#146988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants