Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Apr 17, 2024

Reland #146558, reverted in #146880 due to an outdated test result

Original description

  • Update CS and googlesource.com link branches
  • Update GitHub /blob/ and /tree/ links

Tested links manually and fixes a few broken or deprecated links

Added a test that validates that master isn't used, except for specified repos.

Part of #121564

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

guidezpl and others added 13 commits April 10, 2024 11:33
Also fix a broken link to Fuschia source
- Update CS and googlesource.com link branches
- Update GitHub /blob/ and /tree/ links

Tested links manually and fixes a few broken or deprecated links

Added a test that validates that `master` isn't used, except for
specified repos.

Part of flutter#121564

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) f: scrolling Viewports, list views, slivers, etc. f: gestures flutter/packages/flutter/gestures repository. a: desktop Running on desktop f: integration_test The flutter/packages/integration_test plugin labels Apr 17, 2024
@guidezpl guidezpl requested a review from TahaTesser April 17, 2024 11:29
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

'╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════\n'
'$lines\n'
'║ See: https://github.com/flutter/flutter/blob/master/dev/tools/gen_defaults to update the token template files.\n'
'║ See: https://github.com/flutter/flutter/blob/main/dev/tools/gen_defaults to update the token template files.\n'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024
@auto-submit auto-submit bot merged commit 4a65a76 into flutter:master Apr 17, 2024
@guidezpl guidezpl deleted the main-rename branch April 17, 2024 14:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
tarrinneal pushed a commit to flutter/packages that referenced this pull request Apr 18, 2024
Roll Flutter from 3882afb to fb110b9 (56 revisions)

flutter/flutter@3882afb...fb110b9

2024-04-18 [email protected] Fix memory
leaks in `MaterialBanner` (flutter/flutter#146963)
2024-04-18 [email protected] Fix memory
leak in data table (flutter/flutter#146892)
2024-04-18 [email protected] Dispose the
curved animation in transition test (flutter/flutter#146961)
2024-04-18 [email protected] Roll Flutter Engine from
5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982)
2024-04-18 [email protected] Roll Flutter Engine from
132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972)
2024-04-18 [email protected] Roll Flutter Engine from
20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969)
2024-04-18 [email protected] [macOS] Migrate
@NSApplicationMain attribute to @main (flutter/flutter#146848)
2024-04-18 [email protected] Roll Flutter Engine from
07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962)
2024-04-18 [email protected] Roll Flutter Engine from
725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960)
2024-04-18 [email protected] Roll Flutter Engine from
624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959)
2024-04-17 [email protected] Roll Flutter Engine from
9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
peter-evans/create-pull-request from 6.0.3 to 6.0.4
(flutter/flutter#146954)
2024-04-17 [email protected] Roll Flutter Engine from
cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946)
2024-04-17 [email protected] Bump meta to 1.14.0
(flutter/flutter#146925)
2024-04-17 [email protected] Make goldenFileComparator a field instead of a
trivial property (flutter/flutter#146800)
2024-04-17 [email protected] Assert that the goldenFileComparator is a
LocalFileComparator (flutter/flutter#146802)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic
(#146931)" (flutter/flutter#146947)
2024-04-17 [email protected] Create web tests
suite & runner_utils (flutter/flutter#146592)
2024-04-17 [email protected] Roll Flutter Engine from
376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940)
2024-04-17 [email protected] Try to be more consistent about deleting test
apps in devicelab logic (flutter/flutter#146931)
2024-04-17 [email protected] Roll Flutter Engine from
bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937)
2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment
(flutter/flutter#146804)
2024-04-17 [email protected]
Roll pub packages (flutter/flutter#146929)
2024-04-17 [email protected] Get rid of _NullElement.
(flutter/flutter#146741)
2024-04-17 [email protected] Roll Flutter Engine from
818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930)
2024-04-17 [email protected] Fix memory
leak in paginated tables (flutter/flutter#146755)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic.
(#146856)" (flutter/flutter#146927)
2024-04-17 [email protected] Roll Flutter Engine from
25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898)
2024-04-17 [email protected] Try to be more consistent about deleting test
apps in devicelab logic. (flutter/flutter#146856)
2024-04-17 [email protected] Unpin frontend_server_client and roll
packages (flutter/flutter#146650)
2024-04-17 [email protected] Roll Packages from
90c876d to d39830e (4 revisions) (flutter/flutter#146895)
2024-04-17 [email protected] Roll Flutter Engine from
0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889)
2024-04-17 [email protected] Reland: Update link
branches to `main` (flutter/flutter#146882)
2024-04-17 [email protected] Roll Flutter Engine from
4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884)
2024-04-17 [email protected] Revert "Update link
branches to `main`" (flutter/flutter#146880)
2024-04-17 [email protected] Fix `Tab` indicator image configuration
doesn't inherit device pixel ratio (flutter/flutter#146812)
2024-04-17 [email protected] Roll Flutter Engine from
1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865)
2024-04-17 [email protected] Update link
branches to `main` (flutter/flutter#146558)
2024-04-17 [email protected] Roll Flutter Engine from
45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863)
2024-04-17 [email protected] Rewrap some lines that are about to get much
longer. (flutter/flutter#146803)
2024-04-17 [email protected] Roll Flutter Engine from
0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862)
2024-04-17 [email protected] Roll Flutter Engine from
31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861)
2024-04-17 [email protected] Roll Flutter Engine from
e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859)
2024-04-17 [email protected] Roll Flutter Engine from
4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857)
2024-04-16 [email protected] Switch to relevant `Remote` constructors
(flutter/flutter#146773)
...
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
Reland flutter#146558, reverted in flutter#146880 due to an outdated test result

## Original description

- Update CS and googlesource.com link branches
- Update GitHub /blob/ and /tree/ links

Tested links manually and fixes a few broken or deprecated links

Added a test that validates that `master` isn't used, except for specified repos.

Part of flutter#121564
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
Roll Flutter from 3882afb to fb110b9 (56 revisions)

flutter/flutter@3882afb...fb110b9

2024-04-18 [email protected] Fix memory
leaks in `MaterialBanner` (flutter/flutter#146963)
2024-04-18 [email protected] Fix memory
leak in data table (flutter/flutter#146892)
2024-04-18 [email protected] Dispose the
curved animation in transition test (flutter/flutter#146961)
2024-04-18 [email protected] Roll Flutter Engine from
5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982)
2024-04-18 [email protected] Roll Flutter Engine from
132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972)
2024-04-18 [email protected] Roll Flutter Engine from
20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969)
2024-04-18 [email protected] [macOS] Migrate
@NSApplicationMain attribute to @main (flutter/flutter#146848)
2024-04-18 [email protected] Roll Flutter Engine from
07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962)
2024-04-18 [email protected] Roll Flutter Engine from
725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960)
2024-04-18 [email protected] Roll Flutter Engine from
624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959)
2024-04-17 [email protected] Roll Flutter Engine from
9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953)
2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump
peter-evans/create-pull-request from 6.0.3 to 6.0.4
(flutter/flutter#146954)
2024-04-17 [email protected] Roll Flutter Engine from
cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946)
2024-04-17 [email protected] Bump meta to 1.14.0
(flutter/flutter#146925)
2024-04-17 [email protected] Make goldenFileComparator a field instead of a
trivial property (flutter/flutter#146800)
2024-04-17 [email protected] Assert that the goldenFileComparator is a
LocalFileComparator (flutter/flutter#146802)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic
(#146931)" (flutter/flutter#146947)
2024-04-17 [email protected] Create web tests
suite & runner_utils (flutter/flutter#146592)
2024-04-17 [email protected] Roll Flutter Engine from
376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940)
2024-04-17 [email protected] Try to be more consistent about deleting test
apps in devicelab logic (flutter/flutter#146931)
2024-04-17 [email protected] Roll Flutter Engine from
bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937)
2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment
(flutter/flutter#146804)
2024-04-17 [email protected]
Roll pub packages (flutter/flutter#146929)
2024-04-17 [email protected] Get rid of _NullElement.
(flutter/flutter#146741)
2024-04-17 [email protected] Roll Flutter Engine from
818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930)
2024-04-17 [email protected] Fix memory
leak in paginated tables (flutter/flutter#146755)
2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Try to be more consistent about deleting test apps in devicelab logic.
(#146856)" (flutter/flutter#146927)
2024-04-17 [email protected] Roll Flutter Engine from
25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898)
2024-04-17 [email protected] Try to be more consistent about deleting test
apps in devicelab logic. (flutter/flutter#146856)
2024-04-17 [email protected] Unpin frontend_server_client and roll
packages (flutter/flutter#146650)
2024-04-17 [email protected] Roll Packages from
90c876d to d39830e (4 revisions) (flutter/flutter#146895)
2024-04-17 [email protected] Roll Flutter Engine from
0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889)
2024-04-17 [email protected] Reland: Update link
branches to `main` (flutter/flutter#146882)
2024-04-17 [email protected] Roll Flutter Engine from
4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884)
2024-04-17 [email protected] Revert "Update link
branches to `main`" (flutter/flutter#146880)
2024-04-17 [email protected] Fix `Tab` indicator image configuration
doesn't inherit device pixel ratio (flutter/flutter#146812)
2024-04-17 [email protected] Roll Flutter Engine from
1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865)
2024-04-17 [email protected] Update link
branches to `main` (flutter/flutter#146558)
2024-04-17 [email protected] Roll Flutter Engine from
45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863)
2024-04-17 [email protected] Rewrap some lines that are about to get much
longer. (flutter/flutter#146803)
2024-04-17 [email protected] Roll Flutter Engine from
0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862)
2024-04-17 [email protected] Roll Flutter Engine from
31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861)
2024-04-17 [email protected] Roll Flutter Engine from
e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859)
2024-04-17 [email protected] Roll Flutter Engine from
4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857)
2024-04-16 [email protected] Switch to relevant `Remote` constructors
(flutter/flutter#146773)
...
@Piinks Piinks mentioned this pull request Jun 3, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs a: desktop Running on desktop a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants