Skip to content

fix test-case for RenderView #146825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
Apr 16, 2024
Merged

fix test-case for RenderView #146825

polina-c merged 2 commits into from
Apr 16, 2024

Conversation

@Dimilkalathiya
Copy link
Contributor

@Dimilkalathiya Dimilkalathiya commented Apr 16, 2024

Root layer is not disposed in RenderView

Fixes #146742

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Apr 16, 2024
@Dimilkalathiya
Copy link
Contributor Author

Dimilkalathiya commented Apr 16, 2024

cc: @polina-c

Looks strange, because the layer seems to be accurately managed by a layer handle.

Yes, everything is managed accurately, but specified test-case use tester.binding.setSurfaceSize(const Size(300, 300)); which needs to be disposed as mentioned in their docs that can be seen on below image

Screenshot 2024-04-16 at 8 38 47 PM

adding addTearDown(() => tester.binding.setSurfaceSize(null)); fixes leak

polina-c
polina-c approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 16, 2024
@polina-c polina-c merged commit 2240998 into flutter:master Apr 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
b924cfc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
488ef74
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
ed6e1de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
b9dc0bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
282002b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
2782495
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
2240998 fix test-case for RenderView (flutter/flutter#146825)
f692e34
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@Dimilkalathiya @gilnobrega
fix test-case for RenderView (flutter#146825)
274d485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Root layer is not disposed in RenderView.

2 participants

@Dimilkalathiya @polina-c