Skip to content

Conversation

@polina-c
Copy link
Contributor

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Apr 14, 2024
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 14, 2024
@polina-c polina-c requested a review from Renzo-Olivares April 14, 2024 21:37
@github-actions github-actions bot added the f: cupertino flutter/packages/flutter/cupertino repository label Apr 14, 2024
@polina-c polina-c changed the title Mark leaking root layer. Update leak related TODOs. Apr 14, 2024
@github-actions github-actions bot added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Apr 14, 2024
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit c4a7cf2 into flutter:master Apr 15, 2024
@polina-c polina-c deleted the mark-layer branch April 15, 2024 18:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2024
Manual roll requested by [email protected]

flutter/flutter@2e748e8...3882afb

2024-04-16 [email protected] Fix leak memory in `Tooltip` and account detail (flutter/flutter#146833)
2024-04-16 [email protected] Fix memory leak in `BottomNavigationBar` (flutter/flutter#146748)
2024-04-16 [email protected] Roll Flutter Engine from cba7678fcfd2 to 71ab8854f14e (2 revisions) (flutter/flutter#146819)
2024-04-16 [email protected] Roll Flutter Engine from 66ad80217898 to cba7678fcfd2 (6 revisions) (flutter/flutter#146811)
2024-04-16 [email protected] Roll pub packages (flutter/flutter#146797)
2024-04-16 [email protected] Roll Flutter Engine from 76fbe31a96b3 to 66ad80217898 (2 revisions) (flutter/flutter#146794)
2024-04-16 [email protected] Roll Flutter Engine from 557ffb1cfda6 to 76fbe31a96b3 (4 revisions) (flutter/flutter#146792)
2024-04-16 [email protected] Roll Flutter Engine from 503e7e8f37f3 to 557ffb1cfda6 (1 revision) (flutter/flutter#146791)
2024-04-16 [email protected] Roll Flutter Engine from 07ae93c9b755 to 503e7e8f37f3 (7 revisions) (flutter/flutter#146790)
2024-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/flutter#146784)
2024-04-15 [email protected] Roll pub packages (flutter/flutter#146782)
2024-04-15 [email protected] Roll Flutter Engine from 84238c411001 to 07ae93c9b755 (3 revisions) (flutter/flutter#146776)
2024-04-15 [email protected] Add hitTestBehavior and rootOverlay to LongPressDraggable constructorâ�¦ (flutter/flutter#146386)
2024-04-15 [email protected] Roll Flutter Engine from 1a13c7d1f40e to 84238c411001 (4 revisions) (flutter/flutter#146775)
2024-04-15 [email protected] Update leak related TODOs. (flutter/flutter#146743)
2024-04-15 [email protected] [Doctor] Improve CocoaPods messages (flutter/flutter#146701)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
)

Manual roll requested by [email protected]

flutter/flutter@2e748e8...3882afb

2024-04-16 [email protected] Fix leak memory in `Tooltip` and account detail (flutter/flutter#146833)
2024-04-16 [email protected] Fix memory leak in `BottomNavigationBar` (flutter/flutter#146748)
2024-04-16 [email protected] Roll Flutter Engine from cba7678fcfd2 to 71ab8854f14e (2 revisions) (flutter/flutter#146819)
2024-04-16 [email protected] Roll Flutter Engine from 66ad80217898 to cba7678fcfd2 (6 revisions) (flutter/flutter#146811)
2024-04-16 [email protected] Roll pub packages (flutter/flutter#146797)
2024-04-16 [email protected] Roll Flutter Engine from 76fbe31a96b3 to 66ad80217898 (2 revisions) (flutter/flutter#146794)
2024-04-16 [email protected] Roll Flutter Engine from 557ffb1cfda6 to 76fbe31a96b3 (4 revisions) (flutter/flutter#146792)
2024-04-16 [email protected] Roll Flutter Engine from 503e7e8f37f3 to 557ffb1cfda6 (1 revision) (flutter/flutter#146791)
2024-04-16 [email protected] Roll Flutter Engine from 07ae93c9b755 to 503e7e8f37f3 (7 revisions) (flutter/flutter#146790)
2024-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/flutter#146784)
2024-04-15 [email protected] Roll pub packages (flutter/flutter#146782)
2024-04-15 [email protected] Roll Flutter Engine from 84238c411001 to 07ae93c9b755 (3 revisions) (flutter/flutter#146776)
2024-04-15 [email protected] Add hitTestBehavior and rootOverlay to LongPressDraggable constructorâ�¦ (flutter/flutter#146386)
2024-04-15 [email protected] Roll Flutter Engine from 1a13c7d1f40e to 84238c411001 (4 revisions) (flutter/flutter#146775)
2024-04-15 [email protected] Update leak related TODOs. (flutter/flutter#146743)
2024-04-15 [email protected] [Doctor] Improve CocoaPods messages (flutter/flutter#146701)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants