Add test for animated_fractionally_sized_box.0.dart API example. #146721

ksokolovskyi · 2024-04-13T13:02:19Z

This PR contributes to #130459

Description

Adds examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart test

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

justinmc

LGTM with nits 👍

examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart

ksokolovskyi · 2024-04-20T13:18:14Z

@justinmc thanks for the review!
I applied suggestions in the latest commit.

justinmc

LGTM with a nit 👍

Thanks for taking the time to expose those constants and test the halfway points! I'll try to find a secondary reviewer.

justinmc · 2024-04-22T21:31:40Z

examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart

Nit: Mayyybe give this a more explicit name. It took me awhile to track down what t was when I saw it used below, though admittedly that's only here in the GitHub UI that it's a problem since I would have used jump to definition in my editor. Maybe curveHalf or something?

It could be argued that this styleguide rule applies or does not apply here: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-abbreviations

Nit: Mayyybe give this a more explicit name. It took me awhile to track down what t was when I saw it used below, though admittedly that's only here in the GitHub UI that it's a problem since I would have used jump to definition in my editor. Maybe curveHalf or something?

It could be argued that this styleguide rule applies or does not apply here: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-abbreviations

t is a variable typically used to represent the animation value in calls to lerp. Since the animation in this case isn't using any particularly confusing arithmetic, I think it would fine to just leave it as is.

ksokolovskyi · 2024-04-26T22:00:54Z

Hi @justinmc @victorsanni, do you know why Google testing keeps failing?

victorsanni

LGTM!

justinmc · 2024-04-30T22:29:42Z

Looks like the failing Google tests should be irrelevant. This will be merged when the tree is green. Thanks for the fixes!

ksokolovskyi · 2024-05-01T14:58:25Z

@justinmc @victorsanni thanks for the review!

…le. (flutter/flutter#146721)

Roll Flutter from d33bb8f to bf7191f (34 revisions) flutter/flutter@d33bb8f...bf7191f 2024-05-02 [email protected] Roll Flutter Engine from b989d239e281 to 1fb36ac9d718 (2 revisions) (flutter/flutter#147713) 2024-05-02 [email protected] Roll Flutter Engine from 3c9c2ce8369e to b989d239e281 (1 revision) (flutter/flutter#147711) 2024-05-02 [email protected] Roll Flutter Engine from 58b031c096ea to 3c9c2ce8369e (2 revisions) (flutter/flutter#147703) 2024-05-02 [email protected] Roll Flutter Engine from fc28057dbd4d to 58b031c096ea (1 revision) (flutter/flutter#147701) 2024-05-02 [email protected] Roll Flutter Engine from bfc6787eedc3 to fc28057dbd4d (1 revision) (flutter/flutter#147700) 2024-05-02 [email protected] Roll Flutter Engine from 7cbef71f4f54 to bfc6787eedc3 (1 revision) (flutter/flutter#147699) 2024-05-02 [email protected] Roll Flutter Engine from 90ce9e5959fc to 7cbef71f4f54 (1 revision) (flutter/flutter#147696) 2024-05-02 [email protected] Roll Flutter Engine from 78dced50c467 to 90ce9e5959fc (1 revision) (flutter/flutter#147695) 2024-05-02 [email protected] add verbose logging to select hot reload/hot restart tests (flutter/flutter#147673) 2024-05-02 [email protected] Roll Flutter Engine from 3087ec1adddd to 78dced50c467 (3 revisions) (flutter/flutter#147693) 2024-05-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#147692) 2024-05-02 [email protected] Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) (flutter/flutter#147688) 2024-05-02 [email protected] Allow explicit exclusion of packages from pinned packages in `flutter update-packages --force-update` (flutter/flutter#147679) 2024-05-02 [email protected] Implement getDryBaseline for Stack and Overlay (flutter/flutter#146253) 2024-05-02 [email protected] Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) (flutter/flutter#147681) 2024-05-02 [email protected] Update selectable_text_test.dart (flutter/flutter#147677) 2024-05-01 [email protected] Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) (flutter/flutter#147678) 2024-05-01 [email protected] Implement computeDryBaseline for `RenderWrap` (flutter/flutter#146260) 2024-05-01 [email protected] Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) (flutter/flutter#147675) 2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.0 to 4.3.1 (flutter/flutter#147674) 2024-05-01 [email protected] Remove obsolete performance analysis tools. (flutter/flutter#147663) 2024-05-01 [email protected] Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) (flutter/flutter#147670) 2024-05-01 [email protected] fix DropdownMenu overflow (flutter/flutter#147233) 2024-05-01 [email protected] [web] remove platform_messages_integration test (flutter/flutter#147654) 2024-05-01 [email protected] Fix `TextField` horizontal drag conflicts (flutter/flutter#147341) 2024-05-01 [email protected] `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#147472) 2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Draggable feedback positioning (#145647)" (flutter/flutter#147658) 2024-05-01 [email protected] Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) (flutter/flutter#147655) 2024-05-01 [email protected] add lang attribute to the a11y_assessments app (flutter/flutter#147586) 2024-05-01 [email protected] Draggable feedback positioning (flutter/flutter#145647) 2024-05-01 [email protected] Roll Flutter Engine from 0ce67714ce4c to 0014e0353aa9 (13 revisions) (flutter/flutter#147649) 2024-05-01 [email protected] Add test for animated_fractionally_sized_box.0.dart API example. (flutter/flutter#146721) 2024-05-01 [email protected] Roll Packages from cc47b06 to aea93d2 (5 revisions) (flutter/flutter#147647) 2024-05-01 [email protected] Update reorderable_list.dart to use Dart 3 return switch statement for consistency (flutter/flutter#147505) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…le. (flutter/flutter#146721)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 13, 2024

justinmc approved these changes Apr 16, 2024

View reviewed changes

examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart Outdated Show resolved Hide resolved

ksokolovskyi force-pushed the add-animated-fractionally-sized-box-example-tests branch from 0f63064 to d980372 Compare April 20, 2024 12:55

ksokolovskyi requested a review from justinmc April 22, 2024 21:14

justinmc approved these changes Apr 22, 2024

View reviewed changes

victorsanni approved these changes Apr 23, 2024

View reviewed changes

ksokolovskyi force-pushed the add-animated-fractionally-sized-box-example-tests branch 9 times, most recently from 05298ac to 68677dd Compare April 26, 2024 17:31

ksokolovskyi force-pushed the add-animated-fractionally-sized-box-example-tests branch from fd14c42 to 79595fc Compare April 28, 2024 12:25

ksokolovskyi requested a review from victorsanni April 30, 2024 11:11

ksokolovskyi added 2 commits April 30, 2024 13:11

Add test for animated_fractionally_sized_box.0.dart API example.

3a02165

Apply review suggestions.

88e1030

ksokolovskyi force-pushed the add-animated-fractionally-sized-box-example-tests branch from 79595fc to 88e1030 Compare April 30, 2024 11:11

victorsanni approved these changes Apr 30, 2024

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2024

auto-submit bot merged commit 32ea4b3 into flutter:master May 1, 2024

engine-flutter-autoroll mentioned this pull request May 2, 2024

Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions) flutter/packages#6637

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2024

32ea4b3 Add test for animated_fractionally_sized_box.0.dart API examp…

4580697

…le. (flutter/flutter#146721)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

32ea4b3 Add test for animated_fractionally_sized_box.0.dart API examp…

0d9aba2

…le. (flutter/flutter#146721)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add test for animated_fractionally_sized_box.0.dart API example. #146721

Add test for animated_fractionally_sized_box.0.dart API example. #146721

Uh oh!

ksokolovskyi commented Apr 13, 2024

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

ksokolovskyi commented Apr 20, 2024

Uh oh!

justinmc left a comment

Uh oh!

justinmc Apr 22, 2024

Uh oh!

victorsanni Apr 22, 2024

Uh oh!

ksokolovskyi commented Apr 26, 2024

Uh oh!

victorsanni left a comment

Uh oh!

justinmc commented Apr 30, 2024

Uh oh!

ksokolovskyi commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add test for animated_fractionally_sized_box.0.dart API example. #146721

Add test for animated_fractionally_sized_box.0.dart API example. #146721

Uh oh!

Conversation

ksokolovskyi commented Apr 13, 2024

Description

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ksokolovskyi commented Apr 20, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

victorsanni Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Apr 26, 2024

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Apr 30, 2024

Uh oh!

ksokolovskyi commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants