[Doctor] Improve CocoaPods messages #146701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tool
loic-sharma
force-pushed
the
doctor_cocoapods_reword
branch
from
4e45e24 to
21a388f
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2024
Manual roll requested by [email protected] flutter/flutter@2e748e8...3882afb 2024-04-16 [email protected] Fix leak memory in `Tooltip` and account detail (flutter/flutter#146833) 2024-04-16 [email protected] Fix memory leak in `BottomNavigationBar` (flutter/flutter#146748) 2024-04-16 [email protected] Roll Flutter Engine from cba7678fcfd2 to 71ab8854f14e (2 revisions) (flutter/flutter#146819) 2024-04-16 [email protected] Roll Flutter Engine from 66ad80217898 to cba7678fcfd2 (6 revisions) (flutter/flutter#146811) 2024-04-16 [email protected] Roll pub packages (flutter/flutter#146797) 2024-04-16 [email protected] Roll Flutter Engine from 76fbe31a96b3 to 66ad80217898 (2 revisions) (flutter/flutter#146794) 2024-04-16 [email protected] Roll Flutter Engine from 557ffb1cfda6 to 76fbe31a96b3 (4 revisions) (flutter/flutter#146792) 2024-04-16 [email protected] Roll Flutter Engine from 503e7e8f37f3 to 557ffb1cfda6 (1 revision) (flutter/flutter#146791) 2024-04-16 [email protected] Roll Flutter Engine from 07ae93c9b755 to 503e7e8f37f3 (7 revisions) (flutter/flutter#146790) 2024-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/flutter#146784) 2024-04-15 [email protected] Roll pub packages (flutter/flutter#146782) 2024-04-15 [email protected] Roll Flutter Engine from 84238c411001 to 07ae93c9b755 (3 revisions) (flutter/flutter#146776) 2024-04-15 [email protected] Add hitTestBehavior and rootOverlay to LongPressDraggable constructor� (flutter/flutter#146386) 2024-04-15 [email protected] Roll Flutter Engine from 1a13c7d1f40e to 84238c411001 (4 revisions) (flutter/flutter#146775) 2024-04-15 [email protected] Update leak related TODOs. (flutter/flutter#146743) 2024-04-15 [email protected] [Doctor] Improve CocoaPods messages (flutter/flutter#146701) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
This tweaks the Flutter doctor messages for CocoaPods.
This also switches the "unknown version" error to link to the update instructions instead of the installation instructions; the user has already installed CocoaPods in this scenario.
Example error before:
```
� CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
```
Example error after:
```
� CocoaPods not installed.
CocoaPods is a package manager for iOS or macOS platform code.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
For installation instructions, see https://guides.cocoapods.org/using/getting-started.html#installation
```
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
) Manual roll requested by [email protected] flutter/flutter@2e748e8...3882afb 2024-04-16 [email protected] Fix leak memory in `Tooltip` and account detail (flutter/flutter#146833) 2024-04-16 [email protected] Fix memory leak in `BottomNavigationBar` (flutter/flutter#146748) 2024-04-16 [email protected] Roll Flutter Engine from cba7678fcfd2 to 71ab8854f14e (2 revisions) (flutter/flutter#146819) 2024-04-16 [email protected] Roll Flutter Engine from 66ad80217898 to cba7678fcfd2 (6 revisions) (flutter/flutter#146811) 2024-04-16 [email protected] Roll pub packages (flutter/flutter#146797) 2024-04-16 [email protected] Roll Flutter Engine from 76fbe31a96b3 to 66ad80217898 (2 revisions) (flutter/flutter#146794) 2024-04-16 [email protected] Roll Flutter Engine from 557ffb1cfda6 to 76fbe31a96b3 (4 revisions) (flutter/flutter#146792) 2024-04-16 [email protected] Roll Flutter Engine from 503e7e8f37f3 to 557ffb1cfda6 (1 revision) (flutter/flutter#146791) 2024-04-16 [email protected] Roll Flutter Engine from 07ae93c9b755 to 503e7e8f37f3 (7 revisions) (flutter/flutter#146790) 2024-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/flutter#146784) 2024-04-15 [email protected] Roll pub packages (flutter/flutter#146782) 2024-04-15 [email protected] Roll Flutter Engine from 84238c411001 to 07ae93c9b755 (3 revisions) (flutter/flutter#146776) 2024-04-15 [email protected] Add hitTestBehavior and rootOverlay to LongPressDraggable constructor� (flutter/flutter#146386) 2024-04-15 [email protected] Roll Flutter Engine from 1a13c7d1f40e to 84238c411001 (4 revisions) (flutter/flutter#146775) 2024-04-15 [email protected] Update leak related TODOs. (flutter/flutter#146743) 2024-04-15 [email protected] [Doctor] Improve CocoaPods messages (flutter/flutter#146701) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the Flutter doctor messages for CocoaPods.
This also switches the "unknown version" error to link to the update instructions instead of the installation instructions; the user has already installed CocoaPods in this scenario.
Example error before:
Example error after:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.