Add missing `overlayColor` property in `styleFrom` methods #146685

TahaTesser · 2024-04-12T12:28:40Z

fixes Add missing overlayColor property in styleFrom methods

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

enum Sizes { extraSmall, small, medium, large, extraLarge }

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: <Widget>[
              Text('styleFrom(overlayColor: Colors.red)', style: Theme.of(context).textTheme.titleLarge),
              TextButton(
                style: TextButton.styleFrom(overlayColor: Colors.red),
                onPressed: () {},
                child: const Text('TextButton'),
              ),
              IconButton(
                style: IconButton.styleFrom(
                  overlayColor: Colors.red,
                ),
                onPressed: () {},
                icon: const Icon(Icons.add),
              ),
              MenuBar(
                children: [
                  MenuItemButton(
                    style: MenuItemButton.styleFrom(overlayColor: Colors.red),
                    child: const Text('MenuItemButton'),
                    onPressed: () {},
                  ),
                  SubmenuButton(
                    style: SubmenuButton.styleFrom(overlayColor: Colors.red),
                    menuChildren: [
                      MenuItemButton(
                        child: const Text('MenuItemButton'),
                        onPressed: () {},
                      ),
                    ],
                    child: const Text('SubmenuButton'),
                  ),
                ],
              ),
              SegmentedButton<Sizes>(
                style:
                    SegmentedButton.styleFrom(overlayColor: Colors.red),
                segments: const <ButtonSegment<Sizes>>[
                  ButtonSegment<Sizes>(
                      value: Sizes.extraSmall, label: Text('XS')),
                  ButtonSegment<Sizes>(value: Sizes.small, label: Text('S')),
                  ButtonSegment<Sizes>(value: Sizes.medium, label: Text('M')),
                  ButtonSegment<Sizes>(
                    value: Sizes.large,
                    label: Text('L'),
                  ),
                  ButtonSegment<Sizes>(
                      value: Sizes.extraLarge, label: Text('XL')),
                ],
                selected: const {Sizes.medium},
                onSelectionChanged: (Set<Sizes> newSelection) {},
                multiSelectionEnabled: true,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Preview

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TahaTesser · 2024-04-23T12:09:35Z

@HansMuller
This PR adds the overlayColor prop you added in Buttons #142762

HansMuller

Thanks for this update! LGTM

packages/flutter/lib/src/material/icon_button.dart

…lutter/flutter#146685)

flutter/flutter@77043ba...dba4f77 2024-04-24 [email protected] Fix memory leaks in `BottomNavigationBar` (flutter/flutter#147213) 2024-04-24 [email protected] Disable leak tracking for selection text area (flutter/flutter#147273) 2024-04-24 [email protected] Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685) 2024-04-24 [email protected] Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293) 2024-04-24 [email protected] Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281) 2024-04-24 [email protected] Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276) 2024-04-24 [email protected] Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272) 2024-04-24 [email protected] Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270) 2024-04-24 [email protected] Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267) 2024-04-23 [email protected] Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266) 2024-04-23 [email protected] Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264) 2024-04-23 [email protected] Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843) 2024-04-23 [email protected] Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722) 2024-04-23 [email protected] Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962) 2024-04-23 [email protected] Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262) 2024-04-23 [email protected] Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258) 2024-04-23 [email protected] Add test for focus_node.0.dart API example. (flutter/flutter#146943) 2024-04-23 [email protected] Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255) 2024-04-23 [email protected] Refactor framework + test harness tests (flutter/flutter#146213) 2024-04-23 [email protected] Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509) 2024-04-23 [email protected] Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248) 2024-04-23 [email protected] Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195) 2024-04-23 [email protected] Add test for animated_align.0.dart API example. (flutter/flutter#146719) 2024-04-23 [email protected] Fix typos related to Navigator (flutter/flutter#147221) 2024-04-23 [email protected] Fix memory leak in switch painter (flutter/flutter#147228) 2024-04-23 [email protected] Add test for animated_positioned.0.dart API example. (flutter/flutter#146720) 2024-04-23 [email protected] Update icon tree shaker to allow system font fallback (flutter/flutter#147202) 2024-04-23 [email protected] `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293) 2024-04-23 [email protected] Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241) 2024-04-23 [email protected] Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#146685)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 12, 2024

TahaTesser force-pushed the overlayColor_styleFrom branch from aab62df to b630fe6 Compare April 12, 2024 13:54

TahaTesser marked this pull request as ready for review April 12, 2024 14:14

TahaTesser requested a review from HansMuller April 12, 2024 14:58

HansMuller approved these changes Apr 23, 2024

View reviewed changes

packages/flutter/lib/src/material/icon_button.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/icon_button.dart Outdated Show resolved Hide resolved

TahaTesser added 2 commits April 24, 2024 10:46

Add missing overlayColor property in styleFrom methods

1714d15

Address feedback

25b8921

TahaTesser force-pushed the overlayColor_styleFrom branch from b630fe6 to 25b8921 Compare April 24, 2024 08:12

TahaTesser added 2 commits April 24, 2024 11:48

Update SegmentedButton template to address feedback

64a2110

Kick tests

db94a57

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2024

auto-submit bot merged commit fa85f69 into flutter:master Apr 24, 2024

TahaTesser deleted the overlayColor_styleFrom branch April 24, 2024 12:43

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to fa85f69e47d8 (28 revisions) flutter/packages#6604

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

fa85f69 Add missing overlayColor property in styleFrom methods (f…

3dd3964

…lutter/flutter#146685)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to 2676c84a90d2 (29 revisions) flutter/packages#6606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

fa85f69 Add missing overlayColor property in styleFrom methods (f…

3e1e0b4

…lutter/flutter#146685)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) flutter/packages#6607

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

fa85f69 Add missing overlayColor property in styleFrom methods (f…

710e6d8

…lutter/flutter#146685)

HansMuller mentioned this pull request Apr 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

fa85f69 Add missing overlayColor property in styleFrom methods (f…

bcec3e3

…lutter/flutter#146685)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing `overlayColor` property in `styleFrom` methods #146685

Add missing `overlayColor` property in `styleFrom` methods #146685

Uh oh!

TahaTesser commented Apr 12, 2024

Uh oh!

TahaTesser commented Apr 23, 2024

Uh oh!

HansMuller left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add missing overlayColor property in styleFrom methods #146685

Add missing overlayColor property in styleFrom methods #146685

Uh oh!

Conversation

TahaTesser commented Apr 12, 2024

Code sample

Preview

Pre-launch Checklist

Uh oh!

TahaTesser commented Apr 23, 2024

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add missing `overlayColor` property in `styleFrom` methods #146685

Add missing `overlayColor` property in `styleFrom` methods #146685