Skip to content

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 12, 2024

Since Flutter no longer supports Windows 7.x or 8.x, this eliminates support from the Windows app template. No tests to eliminate, since Windows 7 and 8 were "best-efforts" tier and untested.

Fixes: #140830
RFC: http://flutter.dev/go/flutter-drop-win7-2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Eliminates support (by default) for Windows 7 and 8 apps in the template.

Issue: flutter#140830
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop labels Apr 12, 2024
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2024
@auto-submit auto-submit bot merged commit a34086a into flutter:master Apr 12, 2024
@cbracken cbracken deleted the drop-win-78 branch April 12, 2024 01:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 12, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
Since Flutter no longer supports Windows 7.x or 8.x, this eliminates support from the Windows app template. No tests to eliminate, since Windows 7 and 8 were "best-efforts" tier and untested.

Fixes: flutter#140830
RFC: http://flutter.dev/go/flutter-drop-win7-2024
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Windows 7 and 8 to unsupported tier; increase minimum supported Windows version to Windows 10

2 participants