Skip to content

Roll pub packages #146642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flutter-pub-roller-bot wants to merge 1 commit into from
Closed

Roll pub packages #146642

flutter-pub-roller-bot wants to merge 1 commit into from

Conversation

@flutter-pub-roller-bot
Copy link
Contributor

@flutter-pub-roller-bot flutter-pub-roller-bot commented Apr 11, 2024

This PR was generated by flutter update-packages --force-upgrade.

@flutter-pub-roller-bot flutter-pub-roller-bot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Apr 11, 2024
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Apr 11, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 11, 2024

auto label is removed for flutter/flutter/146642, due to - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2024
@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 11, 2024

Looks like package:args changed an interface

RUNNING: cd .; bin/flutter analyze --flutter-repo
workingDirectory: /b/s/w/ir/x/w/flutter, executable: /b/s/w/ir/x/w/flutter/bin/flutter, arguments: [analyze, --flutter-repo]
Analyzing flutter...                                            

  error • Missing concrete implementations of 'ArgResults.flag', 'ArgResults.multiOption', and 'ArgResults.option' • dev/conductor/core/test/common.dart:57:7 • non_abstract_class_inherits_abstract_member
  error • Missing concrete implementations of 'ArgResults.flag', 'ArgResults.multiOption', and 'ArgResults.option' • dev/conductor/core/test/globals_test.dart:167:7 • non_abstract_class_inherits_abstract_member

@christopherfujino christopherfujino mentioned this pull request Apr 11, 2024
Merged
@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 11, 2024

This can be closed once https://github.com/flutter/flutter/pull/146646/files merges.

auto-submit bot pushed a commit that referenced this pull request Apr 12, 2024
@christopherfujino
[flutter_tools] Fix conductor for package args roll (#146646)
7a30d2b 
The interface for `ArgResults` from `package:args` has added new fields. Change the implementations of these in the conductor to extend `Fake` so that these aren't analyzer errors.

This broke the pub roll here: #146642 (comment)
@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 12, 2024

Closing this as superceded by https://github.com/flutter/flutter/pull/146646/files

gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@christopherfujino @gilnobrega
[flutter_tools] Fix conductor for package args roll (flutter#146646)
c6d5ba8 
The interface for `ArgResults` from `package:args` has added new fields. Change the implementations of these in the conductor to extend `Fake` so that these aren't analyzer errors.

This broke the pub roll here: flutter#146642 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flutter-pub-roller-bot @christopherfujino @fluttergithubbot