Create web tests suite & update utils #146592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2024
Closed
This was referenced Apr 11, 2024
Closed
Contributor
Author
|
cc @godofredoc This change is a refactor of the runDartTest but doesn't aim to change any of the logic. I see that there is an open issue to combine the run test wrapper methods. |
9 tasks
Contributor
|
I'm guessing the conflicts are with another of your PRs? |
Contributor
Author
|
@christopherfujino Yes, and auto-resolve failing to delete the old web_long_running_tests file. I addressed all the conflicts and it should be good to go |
sealesj
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/146592, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
sealesj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2024
26 tasks
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 18, 2024
Roll Flutter from 3882afb to fb110b9 (56 revisions) flutter/flutter@3882afb...fb110b9 2024-04-18 [email protected] Fix memory leaks in `MaterialBanner` (flutter/flutter#146963) 2024-04-18 [email protected] Fix memory leak in data table (flutter/flutter#146892) 2024-04-18 [email protected] Dispose the curved animation in transition test (flutter/flutter#146961) 2024-04-18 [email protected] Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982) 2024-04-18 [email protected] Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972) 2024-04-18 [email protected] Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969) 2024-04-18 [email protected] [macOS] Migrate @NSApplicationMain attribute to @main (flutter/flutter#146848) 2024-04-18 [email protected] Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962) 2024-04-18 [email protected] Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960) 2024-04-18 [email protected] Roll Flutter Engine from 624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959) 2024-04-17 [email protected] Roll Flutter Engine from 9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.3 to 6.0.4 (flutter/flutter#146954) 2024-04-17 [email protected] Roll Flutter Engine from cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946) 2024-04-17 [email protected] Bump meta to 1.14.0 (flutter/flutter#146925) 2024-04-17 [email protected] Make goldenFileComparator a field instead of a trivial property (flutter/flutter#146800) 2024-04-17 [email protected] Assert that the goldenFileComparator is a LocalFileComparator (flutter/flutter#146802) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" (flutter/flutter#146947) 2024-04-17 [email protected] Create web tests suite & runner_utils (flutter/flutter#146592) 2024-04-17 [email protected] Roll Flutter Engine from 376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic (flutter/flutter#146931) 2024-04-17 [email protected] Roll Flutter Engine from bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937) 2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment (flutter/flutter#146804) 2024-04-17 [email protected] Roll pub packages (flutter/flutter#146929) 2024-04-17 [email protected] Get rid of _NullElement. (flutter/flutter#146741) 2024-04-17 [email protected] Roll Flutter Engine from 818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930) 2024-04-17 [email protected] Fix memory leak in paginated tables (flutter/flutter#146755) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" (flutter/flutter#146927) 2024-04-17 [email protected] Roll Flutter Engine from 25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic. (flutter/flutter#146856) 2024-04-17 [email protected] Unpin frontend_server_client and roll packages (flutter/flutter#146650) 2024-04-17 [email protected] Roll Packages from 90c876d to d39830e (4 revisions) (flutter/flutter#146895) 2024-04-17 [email protected] Roll Flutter Engine from 0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889) 2024-04-17 [email protected] Reland: Update link branches to `main` (flutter/flutter#146882) 2024-04-17 [email protected] Roll Flutter Engine from 4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884) 2024-04-17 [email protected] Revert "Update link branches to `main`" (flutter/flutter#146880) 2024-04-17 [email protected] Fix `Tab` indicator image configuration doesn't inherit device pixel ratio (flutter/flutter#146812) 2024-04-17 [email protected] Roll Flutter Engine from 1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865) 2024-04-17 [email protected] Update link branches to `main` (flutter/flutter#146558) 2024-04-17 [email protected] Roll Flutter Engine from 45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863) 2024-04-17 [email protected] Rewrap some lines that are about to get much longer. (flutter/flutter#146803) 2024-04-17 [email protected] Roll Flutter Engine from 0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862) 2024-04-17 [email protected] Roll Flutter Engine from 31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861) 2024-04-17 [email protected] Roll Flutter Engine from e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859) 2024-04-17 [email protected] Roll Flutter Engine from 4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857) 2024-04-16 [email protected] Switch to relevant `Remote` constructors (flutter/flutter#146773) ...
sealesj
changed the title
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
Move from `test.dart` into new `runner_utils.dart` file: - shard calculation related methods + `shuffleSeed` logic - env variable flag calculation - runner wrapper methods `runDartTest` and `_runFromList` Create web tests suite class containing: - web long running tests - runWebHtmlUnitTests - runWebCanvasKitUnitTests - runWebSkwasmUnitTests - the associate helper methods with the above
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
The flutterroot param is accessible from the util function after the recent refactor of utils flutter#146592 so this change cleans up the references to the suite runners to make them simpler. Part of flutter#145482
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Roll Flutter from 3882afb to fb110b9 (56 revisions) flutter/flutter@3882afb...fb110b9 2024-04-18 [email protected] Fix memory leaks in `MaterialBanner` (flutter/flutter#146963) 2024-04-18 [email protected] Fix memory leak in data table (flutter/flutter#146892) 2024-04-18 [email protected] Dispose the curved animation in transition test (flutter/flutter#146961) 2024-04-18 [email protected] Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982) 2024-04-18 [email protected] Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972) 2024-04-18 [email protected] Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969) 2024-04-18 [email protected] [macOS] Migrate @NSApplicationMain attribute to @main (flutter/flutter#146848) 2024-04-18 [email protected] Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962) 2024-04-18 [email protected] Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960) 2024-04-18 [email protected] Roll Flutter Engine from 624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959) 2024-04-17 [email protected] Roll Flutter Engine from 9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.3 to 6.0.4 (flutter/flutter#146954) 2024-04-17 [email protected] Roll Flutter Engine from cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946) 2024-04-17 [email protected] Bump meta to 1.14.0 (flutter/flutter#146925) 2024-04-17 [email protected] Make goldenFileComparator a field instead of a trivial property (flutter/flutter#146800) 2024-04-17 [email protected] Assert that the goldenFileComparator is a LocalFileComparator (flutter/flutter#146802) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" (flutter/flutter#146947) 2024-04-17 [email protected] Create web tests suite & runner_utils (flutter/flutter#146592) 2024-04-17 [email protected] Roll Flutter Engine from 376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic (flutter/flutter#146931) 2024-04-17 [email protected] Roll Flutter Engine from bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937) 2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment (flutter/flutter#146804) 2024-04-17 [email protected] Roll pub packages (flutter/flutter#146929) 2024-04-17 [email protected] Get rid of _NullElement. (flutter/flutter#146741) 2024-04-17 [email protected] Roll Flutter Engine from 818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930) 2024-04-17 [email protected] Fix memory leak in paginated tables (flutter/flutter#146755) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" (flutter/flutter#146927) 2024-04-17 [email protected] Roll Flutter Engine from 25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic. (flutter/flutter#146856) 2024-04-17 [email protected] Unpin frontend_server_client and roll packages (flutter/flutter#146650) 2024-04-17 [email protected] Roll Packages from 90c876d to d39830e (4 revisions) (flutter/flutter#146895) 2024-04-17 [email protected] Roll Flutter Engine from 0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889) 2024-04-17 [email protected] Reland: Update link branches to `main` (flutter/flutter#146882) 2024-04-17 [email protected] Roll Flutter Engine from 4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884) 2024-04-17 [email protected] Revert "Update link branches to `main`" (flutter/flutter#146880) 2024-04-17 [email protected] Fix `Tab` indicator image configuration doesn't inherit device pixel ratio (flutter/flutter#146812) 2024-04-17 [email protected] Roll Flutter Engine from 1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865) 2024-04-17 [email protected] Update link branches to `main` (flutter/flutter#146558) 2024-04-17 [email protected] Roll Flutter Engine from 45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863) 2024-04-17 [email protected] Rewrap some lines that are about to get much longer. (flutter/flutter#146803) 2024-04-17 [email protected] Roll Flutter Engine from 0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862) 2024-04-17 [email protected] Roll Flutter Engine from 31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861) 2024-04-17 [email protected] Roll Flutter Engine from e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859) 2024-04-17 [email protected] Roll Flutter Engine from 4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857) 2024-04-16 [email protected] Switch to relevant `Remote` constructors (flutter/flutter#146773) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from
test.dartinto newrunner_utils.dartfile:shuffleSeedlogicrunDartTestand_runFromListCreate web tests suite class containing:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.