- Fixes _DropdownMenuState leaking text controller [prod-leak-fix] #146571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes particular test not handling text controller dispose
github-actions
bot
added
framework
Dimilkalathiya
changed the title
Contributor
Author
|
cc: @polina-c |
polina-c
reviewed
Apr 10, 2024
| currentHighlight = widget.enableSearch ? i : null; | ||
| widget.onSelected?.call(entry.value); | ||
| _localTextEditingController?.dispose(); | ||
| _localTextEditingController = null; |
Contributor
There was a problem hiding this comment.
Why we need to dispose _localTextEditingController on every click? It will cause recreation of the controller.
Contributor
There was a problem hiding this comment.
This getter recreates controller if there is no controller:
TextEditingController get _textEditingController {
return widget.controller ?? (_localTextEditingController ??= TextEditingController());
}
Contributor
Author
There was a problem hiding this comment.
Yes, having getter which creates disposable class is quite troublesome even if we fix this issue if bounds to cause issue if new feature is introduced
i'll try to remove getter and minimise instantiation limited to initState and didUpdateWidget
polina-c
reviewed
Apr 10, 2024
| selection: TextSelection.collapsed(offset: entry.label.length), | ||
| ); | ||
| widget.onSelected?.call(entry.value); | ||
| _localTextEditingController?.dispose(); |
Contributor
There was a problem hiding this comment.
The same comment here.
It will cause recreate of controller on each onEditingComplete.
Contributor
Author
|
Hii @polina-c, Have updated PR as per discussed, let me know if this is good or you'd have some improvement in mind 🤔 |
Contributor
|
Thanks. Originally the getter was creating local controller if one in widget is not provided. If we understand what was wrong, we may find smaller code change for fix. Or, we may discover some bigger bug in Flutter Framework, that is always a good thing. |
Contributor
Author
|
Hii @polina-c Yes, its nice idea to understand what is causing this bug, so i did some test and it turns out that 
which is there because of copy-paste issue #118731 so it can change focus. which causes if we simply remove post frame callback function and call some additional details that might help:-
but what do you think? we should merge this PR? or we should be changing |
polina-c
approved these changes
Apr 14, 2024
Contributor
|
Thank you for research! |
polina-c
added
the
a: leak tracking
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 15, 2024
Manual roll requested by [email protected] flutter/flutter@53cba24...2e748e8 2024-04-15 [email protected] Implementing control flow collections (flutter/flutter#146601) 2024-04-15 [email protected] Roll Packages from 78f684c to 6698b2d (3 revisions) (flutter/flutter#146761) 2024-04-15 [email protected] test: Fix memory leak in transitions test (flutter/flutter#146747) 2024-04-15 [email protected] Fix filled text field active indicator overflows container bounds (flutter/flutter#146637) 2024-04-14 [email protected] - Fixes _DropdownMenuState leaking text controller (flutter/flutter#146571) 2024-04-13 [email protected] Fix memory leaks in `FloatingActionButton` (flutter/flutter#146711) 2024-04-12 [email protected] Roll Flutter Engine from 0e56e3dffe43 to 1a13c7d1f40e (2 revisions) (flutter/flutter#146703) 2024-04-12 [email protected] Roll pub packages (flutter/flutter#146704) 2024-04-12 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.2 to 6.0.3 (flutter/flutter#146702) 2024-04-12 [email protected] Avoid forwarding the data after socket is disconnected. (flutter/flutter#146665) 2024-04-12 [email protected] [flutter_tools] Fix conductor for package args roll (flutter/flutter#146646) 2024-04-12 [email protected] Roll Flutter Engine from 6b37b170998e to 0e56e3dffe43 (4 revisions) (flutter/flutter#146698) 2024-04-12 [email protected] Light sliver clean up before SliverTree (flutter/flutter#146696) 2024-04-12 [email protected] Fix label text color is wrong for a focused and hovered TextField (flutter/flutter#146572) 2024-04-12 [email protected] Fix `getOffsetForCaret` crash (flutter/flutter#146669) 2024-04-12 [email protected] Update gen_keycodes templates (flutter/flutter#146481) 2024-04-12 [email protected] Support `flutter run --wasm` and `flutter drive --wasm`. (flutter/flutter#146231) 2024-04-12 [email protected] Fix curved animation memory leak for scrollbar (flutter/flutter#146670) 2024-04-12 [email protected] Roll Packages from e98839a to 78f684c (6 revisions) (flutter/flutter#146691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
) Manual roll requested by [email protected] flutter/flutter@53cba24...2e748e8 2024-04-15 [email protected] Implementing control flow collections (flutter/flutter#146601) 2024-04-15 [email protected] Roll Packages from 78f684c to 6698b2d (3 revisions) (flutter/flutter#146761) 2024-04-15 [email protected] test: Fix memory leak in transitions test (flutter/flutter#146747) 2024-04-15 [email protected] Fix filled text field active indicator overflows container bounds (flutter/flutter#146637) 2024-04-14 [email protected] - Fixes _DropdownMenuState leaking text controller (flutter/flutter#146571) 2024-04-13 [email protected] Fix memory leaks in `FloatingActionButton` (flutter/flutter#146711) 2024-04-12 [email protected] Roll Flutter Engine from 0e56e3dffe43 to 1a13c7d1f40e (2 revisions) (flutter/flutter#146703) 2024-04-12 [email protected] Roll pub packages (flutter/flutter#146704) 2024-04-12 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.2 to 6.0.3 (flutter/flutter#146702) 2024-04-12 [email protected] Avoid forwarding the data after socket is disconnected. (flutter/flutter#146665) 2024-04-12 [email protected] [flutter_tools] Fix conductor for package args roll (flutter/flutter#146646) 2024-04-12 [email protected] Roll Flutter Engine from 6b37b170998e to 0e56e3dffe43 (4 revisions) (flutter/flutter#146698) 2024-04-12 [email protected] Light sliver clean up before SliverTree (flutter/flutter#146696) 2024-04-12 [email protected] Fix label text color is wrong for a focused and hovered TextField (flutter/flutter#146572) 2024-04-12 [email protected] Fix `getOffsetForCaret` crash (flutter/flutter#146669) 2024-04-12 [email protected] Update gen_keycodes templates (flutter/flutter#146481) 2024-04-12 [email protected] Support `flutter run --wasm` and `flutter drive --wasm`. (flutter/flutter#146231) 2024-04-12 [email protected] Fix curved animation memory leak for scrollbar (flutter/flutter#146670) 2024-04-12 [email protected] Roll Packages from e98839a to 78f684c (6 revisions) (flutter/flutter#146691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
polina-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.