Remove additional references to engine v1 android embedding #146523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
changed the title
github-actions
bot
added
a: tests
This was referenced Apr 9, 2024
gmackall
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
8 tasks
matanlurey
approved these changes
Apr 10, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
test-exempt: Only deleting unused code.
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 11, 2024
flutter/flutter@97cd47a...557fbf5 2024-04-11 [email protected] Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604) 2024-04-11 [email protected] Fix out of sync templates files and add a check (flutter/flutter#145747) 2024-04-11 [email protected] [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269) 2024-04-11 [email protected] Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622) 2024-04-11 [email protected] Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621) 2024-04-11 [email protected] Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567) 2024-04-11 [email protected] Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619) 2024-04-11 [email protected] Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618) 2024-04-11 [email protected] Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617) 2024-04-11 [email protected] Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613) 2024-04-11 [email protected] Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611) 2024-04-11 [email protected] Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609) 2024-04-10 [email protected] Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607) 2024-04-10 [email protected] Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534) 2024-04-10 [email protected] Roll pub packages (flutter/flutter#146606) 2024-04-10 [email protected] Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605) 2024-04-10 [email protected] Remove additional references to engine v1 android embedding (flutter/flutter#146523) 2024-04-10 [email protected] Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591) 2024-04-10 [email protected] Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585) 2024-04-10 [email protected] Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537) 2024-04-10 [email protected] Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577) 2024-04-10 [email protected] Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (flutter/flutter#146575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…146523) flutter/engine#51229 blocked [the roll](flutter#146522) and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again ð��¢ *This category is: uses of plugins that in turn have a `registerWith`, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See flutter/packages#6494 (comment) for details
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@97cd47a...557fbf5 2024-04-11 [email protected] Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604) 2024-04-11 [email protected] Fix out of sync templates files and add a check (flutter/flutter#145747) 2024-04-11 [email protected] [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269) 2024-04-11 [email protected] Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622) 2024-04-11 [email protected] Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621) 2024-04-11 [email protected] Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567) 2024-04-11 [email protected] Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619) 2024-04-11 [email protected] Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618) 2024-04-11 [email protected] Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617) 2024-04-11 [email protected] Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613) 2024-04-11 [email protected] Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611) 2024-04-11 [email protected] Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609) 2024-04-10 [email protected] Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607) 2024-04-10 [email protected] Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534) 2024-04-10 [email protected] Roll pub packages (flutter/flutter#146606) 2024-04-10 [email protected] Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605) 2024-04-10 [email protected] Remove additional references to engine v1 android embedding (flutter/flutter#146523) 2024-04-10 [email protected] Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591) 2024-04-10 [email protected] Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585) 2024-04-10 [email protected] Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537) 2024-04-10 [email protected] Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577) 2024-04-10 [email protected] Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (flutter/flutter#146575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 28, 2024
I have a WIP effort to remove the v1 embedding entirely (flutter/flutter#146523 is the latest pr). `registerWith` references the v1 embedding, which has been deprecated for many years, so this PR removes it from all plugins. Also removes some additional references, see in particular these three commits: 1. Modifies private `ActivityState` class to remove `PluginRegistry.Registrar` member in `image_picker`: c2e4c87 2. Replaces `FlutterMain.getLookupKeyForAsset()` with `FlutterLoader.getLookupKeyForAsset()` in `google_maps` plugin: 73c3de3 3. Removes deprecated `RegistrarFlutterAssetManager` class in `webview_flutter`: cc842c6 Fixes flutter/flutter#70923
ThangVuNguyenViet
pushed a commit
to ThangVuNguyenViet/packages
that referenced
this pull request
May 29, 2024
I have a WIP effort to remove the v1 embedding entirely (flutter/flutter#146523 is the latest pr). `registerWith` references the v1 embedding, which has been deprecated for many years, so this PR removes it from all plugins. Also removes some additional references, see in particular these three commits: 1. Modifies private `ActivityState` class to remove `PluginRegistry.Registrar` member in `image_picker`: flutter@c2e4c87 2. Replaces `FlutterMain.getLookupKeyForAsset()` with `FlutterLoader.getLookupKeyForAsset()` in `google_maps` plugin: flutter@73c3de3 3. Removes deprecated `RegistrarFlutterAssetManager` class in `webview_flutter`: flutter@cc842c6 Fixes flutter/flutter#70923
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Oct 23, 2024
Fixes flutter/flutter#143531 Other failures from the initial attempt are fixed in flutter/flutter#146523
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Fixes flutter#143531 Other failures from the initial attempt are fixed in flutter#146523
Gasol
added a commit
to Gasol/image_crop
that referenced
this pull request
Mar 24, 2025
Legacy APIs are removed in Flutter 3.29. So the `registerWith` method is
removed from the plugin. The plugin should use the new `onAttachedToEngine`
method to register the plugin.
insta_assets_crop-0.1.0\android\src\main\java\dev\legoffmael\imagecrop\ImageCropPlugin.java:36:
error: cannot find symbol import io.flutter.plugin.common.PluginRegistry.Registrar;
References:
- LeGoffMael/insta_assets_picker#60
- https://docs.flutter.dev/release/breaking-changes/plugin-api-migration
- flutter/engine#52022
- flutter/flutter#146523
- https://github.com/flutter/flutter/blob/main/docs/platforms/android/Upgrading-pre-1.12-Android-projects.md
Gasol
added a commit
to Gasol/image_crop
that referenced
this pull request
Mar 24, 2025
Legacy APIs are removed in Flutter 3.29. So the `registerWith` method is
removed from the plugin. The plugin should use the new `onAttachedToEngine`
method to register the plugin.
insta_assets_crop-0.1.0\android\src\main\java\dev\legoffmael\imagecrop\ImageCropPlugin.java:36:
error: cannot find symbol import io.flutter.plugin.common.PluginRegistry.Registrar;
References:
- LeGoffMael/insta_assets_picker#60
- https://docs.flutter.dev/release/breaking-changes/plugin-api-migration
- flutter/engine#52022
- flutter/flutter#146523
- https://github.com/flutter/flutter/blob/main/docs/platforms/android/Upgrading-pre-1.12-Android-projects.md
dko5ki23t
pushed a commit
to dko5ki23t/google_maps_flutter_improved
that referenced
this pull request
May 24, 2025
I have a WIP effort to remove the v1 embedding entirely (flutter/flutter#146523 is the latest pr). `registerWith` references the v1 embedding, which has been deprecated for many years, so this PR removes it from all plugins. Also removes some additional references, see in particular these three commits: 1. Modifies private `ActivityState` class to remove `PluginRegistry.Registrar` member in `image_picker`: flutter/packages@c2e4c87 2. Replaces `FlutterMain.getLookupKeyForAsset()` with `FlutterLoader.getLookupKeyForAsset()` in `google_maps` plugin: flutter/packages@73c3de3 3. Removes deprecated `RegistrarFlutterAssetManager` class in `webview_flutter`: flutter/packages@cc842c6 Fixes flutter/flutter#70923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine#51229 blocked the roll and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time
This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again 😢
*This category is: uses of plugins that in turn have a
registerWith, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See flutter/packages#6494 (comment) for detailsPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.