Allow A/B tests to run as just aggregator of local engine benchmarks #146479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
@hellohuanlin it's not the most elegant thing, but do you want to try this out and see if it works? |
jmagman
changed the title
Contributor
|
Currently having some crash with Admob dependency, but I think it's just my local machine. Will post back I got it addressed. |
hellohuanlin
approved these changes
Apr 11, 2024
Contributor
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
It works! Thanks for making this change.
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 12, 2024
flutter/flutter@557fbf5...53cba24 2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146479) Add `--ab-local-engine-only` flag to change A/B benchmark aggregate behavior to instead run the number of tasks specified with the local engine only, not the default engine. This is useful when you are trying to get average and noise results for a particular engine branch, without needing the default engine every time you change the engine. Fixes flutter#143770
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@557fbf5...53cba24 2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--ab-local-engine-onlyflag to change A/B benchmark aggregate behavior to instead run the number of tasks specified with the local engine only, not the default engine. This is useful when you are trying to get average and noise results for a particular engine branch, without needing the default engine every time you change the engine.Fixes #143770
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.