Update the gradle task to add fallback scheme and host if needed when retrieving deep links. #146470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
tool
hannah-hyj
force-pushed
the
schemes-fall-back
branch
from
45aee21 to
f1de87d
Compare
Merged
7 tasks
chunhtai
reviewed
Apr 11, 2024
| if (!paths) { | ||
| appLinkSettings.deeplinks.add(new Deeplink(scheme: scheme, host: host, path: ".*", intentFilterCheck: intentFilterCheck)) | ||
| } else { | ||
| if(!hosts.isEmpty() || !paths.isEmpty()){ |
Contributor
There was a problem hiding this comment.
do we not fallback if the customers only have schemes?
Member
Author
There was a problem hiding this comment.
yes, the dev tool data table is listed by "domain view" "path view" "single url view" , if there is only schemes, we don't show it.
Contributor
There was a problem hiding this comment.
I think for our current design we can't surface this case, but I think this is something we should go over again with stakeholders.
This is not something we need to figure in this PR though.
chunhtai
approved these changes
Apr 11, 2024
| if (!paths) { | ||
| appLinkSettings.deeplinks.add(new Deeplink(scheme: scheme, host: host, path: ".*", intentFilterCheck: intentFilterCheck)) | ||
| } else { | ||
| if(!hosts.isEmpty() || !paths.isEmpty()){ |
Contributor
There was a problem hiding this comment.
I think for our current design we can't surface this case, but I think this is something we should go over again with stakeholders.
This is not something we need to figure in this PR though.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2024
…ded when retrieving deep links. (flutter/flutter#146470)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 12, 2024
flutter/flutter@557fbf5...53cba24 2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
… retrieving deep links. (flutter#146470) This is to support feature: flutter/devtools#7541 before behavior: do not show this link in the dev tool if there's no scheme or host target behavior: show the link in the dev tool with a error text : ( missing scheme/ missing domain) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@557fbf5...53cba24 2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479) 2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668) 2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666) 2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663) 2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662) 2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470) 2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653) 2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644) 2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450) 2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645) 2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support feature: flutter/devtools#7541
before behavior: do not show this link in the dev tool if there's no scheme or host
target behavior: show the link in the dev tool with a error text : ( missing scheme/ missing domain)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.