Send event to GA3 for telemetry status mismatches between GA3 and GA4 #146453

eliasyishak · 2024-04-08T21:23:24Z

This PR will opt out users from legacy analytics if they have already been opted out from package:unified_analytics.

After successfully merging into main, this will be CP'd into beta and stable channels

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/runner.dart

This reverts commit 58c763b.

dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart

christopherfujino · 2024-04-15T23:10:24Z

packages/flutter_tools/lib/runner.dart

+        // Ensure that anyone opted out of package:unified_analytics is also
+        // opted out of legacy analytics and that analytics is not being suppressed
+        //
+        // Check that the instance for unified_analytics is not a NoOp instance which


I think we should remove this comment about NoOp

christopherfujino · 2024-04-15T23:12:40Z

packages/flutter_tools/lib/runner.dart

+        // TODO(eliasyishak): remove once GA3 sunset, https://github.com/flutter/flutter/issues/128251
+        if (!globals.analytics.telemetryEnabled &&
+            globals.flutterUsage.enabled) {
+          AnalyticsConfigEvent(enabled: false).send();


I'm guessing this sends the opt out event. Will sending the opt-out event count someone as an active user? If so, I'm guessing that this will not actually immediately reduce our count of monthly active users on GA3. Should we also send a special new event (e.g. opted_from_ga3_becaused_opted_out_ga4 or some such) that we can use specifically to do the math?

Yeah I think that would be a great idea, looking into how to add a new event for GA3 now.

Do you think it would still be worth opting out the GA3 users if we have this then? We could leave them opted in and just do a unique count of users that fall into the case where they are opted out of GA4 but remain opted in GA3 with this new event.

We could leave them opted in and just do a unique count of users that fall into the case where they are opted out of GA4 but remain opted in GA3 with this new event.

Yes, this makes sense to me.

Cool, we can also keep the tests from the devicelab. Just waiting for the GA3 export job to confirm the new event works as expected

Took a while for the tables to export but i can confirm that this new event can be something we use to get an aggregate count

I also reverted the test deletions so all this PR is looking to do now is just send a new event

eliasyishak · 2024-04-17T21:36:16Z

friendly ping @christopherfujino

…dy opted out of ga3

christopherfujino

LGTM

auto-submit · 2024-04-18T23:16:18Z

auto label is removed for flutter/flutter/146453, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…46453)

This PR will opt out users from legacy analytics if they have already been opted out from package:unified_analytics. After successfully merging into main, this will be CP'd into beta and stable channels

…46453)

flutter/flutter@fb110b9...98685a0 2024-04-19 [email protected] Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056) 2024-04-19 [email protected] Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046) 2024-04-19 [email protected] Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038) 2024-04-19 [email protected] Update link branches to `main` (continued) (flutter/flutter#146985) 2024-04-19 [email protected] Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035) 2024-04-19 [email protected] Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029) 2024-04-19 [email protected] Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025) 2024-04-19 [email protected] Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023) 2024-04-19 [email protected] Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453) 2024-04-19 [email protected] Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022) 2024-04-18 [email protected] Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017) 2024-04-18 [email protected] Add a breadcrumb for the pub autoroller (flutter/flutter#146786) 2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015) 2024-04-18 [email protected] Redundant message fix (flutter/flutter#143978) 2024-04-18 [email protected] Clean up flutterRoot (flutter/flutter#147010) 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011) 2024-04-18 [email protected] Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256) 2024-04-18 [email protected] Refactor framework coverage tests (flutter/flutter#146210) 2024-04-18 [email protected] Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006) 2024-04-18 [email protected] Changing the renderer on the web target should change its build key. (flutter/flutter#147003) 2024-04-18 [email protected] Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005) 2024-04-18 [email protected] Add generic type for result in PopScope (flutter/flutter#139164) 2024-04-18 [email protected] Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002) 2024-04-18 [email protected] [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958) 2024-04-18 [email protected] Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996) 2024-04-18 [email protected] Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993) 2024-04-18 [email protected] Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992) 2024-04-18 [email protected] Fix memory leaks in navigation rail (flutter/flutter#146988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR will opt out users from legacy analytics if they have already been opted out from package:unified_analytics. After successfully merging into main, this will be CP'd into beta and stable channels

flutter/flutter@fb110b9...98685a0 2024-04-19 [email protected] Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056) 2024-04-19 [email protected] Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046) 2024-04-19 [email protected] Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038) 2024-04-19 [email protected] Update link branches to `main` (continued) (flutter/flutter#146985) 2024-04-19 [email protected] Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035) 2024-04-19 [email protected] Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029) 2024-04-19 [email protected] Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025) 2024-04-19 [email protected] Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023) 2024-04-19 [email protected] Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453) 2024-04-19 [email protected] Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022) 2024-04-18 [email protected] Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017) 2024-04-18 [email protected] Add a breadcrumb for the pub autoroller (flutter/flutter#146786) 2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015) 2024-04-18 [email protected] Redundant message fix (flutter/flutter#143978) 2024-04-18 [email protected] Clean up flutterRoot (flutter/flutter#147010) 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011) 2024-04-18 [email protected] Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256) 2024-04-18 [email protected] Refactor framework coverage tests (flutter/flutter#146210) 2024-04-18 [email protected] Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006) 2024-04-18 [email protected] Changing the renderer on the web target should change its build key. (flutter/flutter#147003) 2024-04-18 [email protected] Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005) 2024-04-18 [email protected] Add generic type for result in PopScope (flutter/flutter#139164) 2024-04-18 [email protected] Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002) 2024-04-18 [email protected] [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958) 2024-04-18 [email protected] Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996) 2024-04-18 [email protected] Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993) 2024-04-18 [email protected] Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992) 2024-04-18 [email protected] Fix memory leaks in navigation rail (flutter/flutter#146988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Opt out users from GA3 if opted out of GA4

87c1ca9

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 8, 2024

Added test

c4fe339

eliasyishak marked this pull request as ready for review April 8, 2024 21:45

eliasyishak requested review from andrewkolos and christopherfujino April 8, 2024 21:45

eliasyishak commented Apr 8, 2024

View reviewed changes

packages/flutter_tools/lib/runner.dart Outdated Show resolved Hide resolved

eliasyishak added 2 commits April 8, 2024 19:00

Don't opt out if NoOp UA instance

e6b7882

Fix typos

a873fad

christopherfujino reviewed Apr 9, 2024

View reviewed changes

packages/flutter_tools/lib/runner.dart Outdated Show resolved Hide resolved

eliasyishak added 9 commits April 9, 2024 09:23

Fix analyze errors

19d7bd1

[WIll revert] For testing in ci

5be7d59

Add'l logging for checking ci

b3ed0e4

Add'l logging

d558dc7

Check for suppression flag

f82e5a8

Remove print statements + use clientId to confirm for noop

34d6f69

Remove devicelab test

eb915bf

Revert test deletion + check for running on bot

58c763b

Revert last commit + remove other tests

a2198dd

This reverts commit 58c763b.

eliasyishak commented Apr 15, 2024

View reviewed changes

dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart Show resolved Hide resolved

christopherfujino reviewed Apr 15, 2024

View reviewed changes

eliasyishak added 2 commits April 17, 2024 11:54

Revert test deletions + use new event

e2d8caa

Revert test

0bed93e

eliasyishak requested a review from christopherfujino April 17, 2024 21:36

add another test verifying we do not send the mismatch event if alrea…

6394344

…dy opted out of ga3

christopherfujino approved these changes Apr 18, 2024

View reviewed changes

eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024

eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024

auto-submit bot merged commit 1c3372f into flutter:master Apr 19, 2024

engine-flutter-autoroll mentioned this pull request Apr 19, 2024

Roll Flutter from fb110b98da15 to 4f7b7c93ffdc (27 revisions) flutter/packages#6576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2024

1c3372f Opt out users from GA3 if opted out of GA4 (flutter/flutter#1…

640a187

…46453)

eliasyishak added the cp: beta cherry pick this pull request to beta release candidate branch label Apr 19, 2024

engine-flutter-autoroll mentioned this pull request Apr 19, 2024

Roll Flutter from fb110b98da15 to 98685a099fdd (28 revisions) flutter/packages#6577

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2024

1c3372f Opt out users from GA3 if opted out of GA4 (flutter/flutter#1…

763f5d8

…46453)

eliasyishak changed the title ~~Opt out users from GA3 if opted out of GA4~~ Send event to GA3 for telemetry status mismatches between GA3 and GA4 Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Send event to GA3 for telemetry status mismatches between GA3 and GA4 #146453

Send event to GA3 for telemetry status mismatches between GA3 and GA4 #146453

Uh oh!

eliasyishak commented Apr 8, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christopherfujino Apr 15, 2024

Uh oh!

christopherfujino Apr 15, 2024

Uh oh!

eliasyishak Apr 16, 2024

Uh oh!

christopherfujino Apr 16, 2024

Uh oh!

eliasyishak Apr 16, 2024 •

edited

Loading

Uh oh!

eliasyishak Apr 17, 2024 •

edited

Loading

Uh oh!

eliasyishak commented Apr 17, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

auto-submit bot commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Send event to GA3 for telemetry status mismatches between GA3 and GA4 #146453

Send event to GA3 for telemetry status mismatches between GA3 and GA4 #146453

Uh oh!

Conversation

eliasyishak commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christopherfujino Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliasyishak commented Apr 17, 2024

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eliasyishak commented Apr 8, 2024 •

edited

Loading

eliasyishak Apr 16, 2024 •

edited

Loading

eliasyishak Apr 17, 2024 •

edited

Loading