Skip to content

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented Apr 8, 2024

Refactor verify codesigned tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing verify codesigned tests

Part of #145482

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj added the team-infra Owned by Infrastructure team label Apr 8, 2024
@sealesj sealesj self-assigned this Apr 8, 2024
@sealesj sealesj marked this pull request as ready for review April 8, 2024 20:55
@sealesj sealesj marked this pull request as draft April 9, 2024 17:03
@sealesj sealesj marked this pull request as ready for review April 9, 2024 19:02
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2024
@auto-submit auto-submit bot merged commit 000101a into flutter:master Apr 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 12, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
Refactor verify codesigned tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing verify codesigned tests

Part of flutter#145482
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@557fbf5...53cba24

2024-04-12 [email protected] Allow A/B tests to run as just aggregator of local engine benchmarks (flutter/flutter#146479)
2024-04-12 [email protected] [Windows] Drop support for Windows 7/8 apps in template (flutter/flutter#146668)
2024-04-12 [email protected] Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) (flutter/flutter#146666)
2024-04-11 [email protected] Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) (flutter/flutter#146663)
2024-04-11 [email protected] Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) (flutter/flutter#146662)
2024-04-11 [email protected] Update the gradle task to add fallback scheme and host if needed when retrieving deep links. (flutter/flutter#146470)
2024-04-11 [email protected] Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) (flutter/flutter#146653)
2024-04-11 [email protected] Fix leaking curved animation. (flutter/flutter#146644)
2024-04-11 [email protected] Refactor verify codesigned (flutter/flutter#146450)
2024-04-11 [email protected] Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) (flutter/flutter#146645)
2024-04-11 [email protected] Roll Packages from 2c15d86 to e98839a (3 revisions) (flutter/flutter#146638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants