Add configurable hitTestBehavior to Scrollable #146403

Amir-P · 2024-04-07T12:05:09Z

This PR adds hitTestBehavior to Scrollable as a configurable member.

Scrollable widget has an opaque hitTestBehavior and won't give widgets under it a chance to catch hits #146401

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

moffatman · 2024-04-07T14:52:50Z

Great change. Just need to fix the trailing spaces pointed out in the analyze check.

Piinks

Hi @Amir-P thanks for contributing!

packages/flutter/test/widgets/scrollable_test.dart

packages/flutter/lib/src/widgets/scroll_view.dart

Piinks · 2024-04-08T19:36:58Z

FYI #145848 may be trying to solve the same issue in a different way. I think this approach is cleaner. 👍

Piinks

Little bit more digging...

I think there are duplicates of this issue:

And there are currently two different proposals out to resolve them:

Amir-P · 2024-04-08T20:12:20Z

FYI #145848 may be trying to solve the same issue in a different way. I think this approach is cleaner. 👍

I think we are addressing totally different problems. The shouldIgnorePointer in Scrollable still disables pointer handling after this PR changes.

Michal-MK · 2024-04-08T20:36:32Z

I initially also tried just setting the GestureDetector to translucent in my digging around... but that does not solve the issue I am having in #145848. This allows pass-though of gestures for overlapping scrollables (at least that is how I understand it), mine is about allowing taps on settling overscrolled scrollables.

Amir-P · 2024-04-09T07:02:13Z

@Piinks I've added another test to make sure widget underneath the Scrollable can be tapped if HitTestBehavior.translucent. Could you check again please?

Piinks

Thanks for the update!

What about NestedScrollView, ListWheelScrollView, TwoDimensionalScrollView, and PageView? EditableText also builds a Scrollable, not sure about that one though..

packages/flutter/lib/src/widgets/scrollable.dart

packages/flutter/test/widgets/scrollable_test.dart

packages/flutter/lib/src/widgets/scroll_view.dart

packages/flutter/lib/src/widgets/scrollable.dart

Co-authored-by: Kate Lovett <[email protected]>

Amir-P · 2024-04-19T11:02:57Z

I think the last commit should do it. 🤞🏻 @Piinks

Piinks

LGTM! Thank you!

chunhtai

LGTM

…er#146403)

flutter/flutter@db8c475...b597dd2 2024-04-30 [email protected] Roll Flutter Engine from 2c1517bbf555 to 0ce67714ce4c (1 revision) (flutter/flutter#147585) 2024-04-30 [email protected] Roll Packages from 87a7c51 to cc47b06 (5 revisions) (flutter/flutter#147580) 2024-04-30 [email protected] Roll Flutter Engine from 1a6ef9957b24 to 2c1517bbf555 (1 revision) (flutter/flutter#147579) 2024-04-30 [email protected] Roll Flutter Engine from 64877c08661d to 1a6ef9957b24 (1 revision) (flutter/flutter#147576) 2024-04-30 [email protected] Roll Flutter Engine from 1d62704cb3d2 to 64877c08661d (1 revision) (flutter/flutter#147567) 2024-04-30 [email protected] Roll Flutter Engine from aace42365fc7 to 1d62704cb3d2 (2 revisions) (flutter/flutter#147566) 2024-04-30 [email protected] Roll Flutter Engine from ea6343846c62 to aace42365fc7 (2 revisions) (flutter/flutter#147563) 2024-04-30 [email protected] Roll Flutter Engine from c519e9dd182b to ea6343846c62 (1 revision) (flutter/flutter#147560) 2024-04-30 [email protected] Roll Flutter Engine from 27bb23221305 to c519e9dd182b (1 revision) (flutter/flutter#147557) 2024-04-30 [email protected] Roll Flutter Engine from 93ccb9ab2cda to 27bb23221305 (2 revisions) (flutter/flutter#147556) 2024-04-30 [email protected] Roll Flutter Engine from c093562677fa to 93ccb9ab2cda (1 revision) (flutter/flutter#147553) 2024-04-29 [email protected] Bump dependencies in Flutter (flutter/flutter#147546) 2024-04-29 [email protected] Add configurable hitTestBehavior to Scrollable (flutter/flutter#146403) 2024-04-29 [email protected] Fix wide `DatePicker` input mode button padding for Material 3 (flutter/flutter#147236) 2024-04-29 [email protected] Roll Flutter Engine from 13c7ac9376a5 to c093562677fa (1 revision) (flutter/flutter#147547) 2024-04-29 [email protected] Roll Flutter Engine from 5165c711771c to 13c7ac9376a5 (1 revision) (flutter/flutter#147542) 2024-04-29 [email protected] Roll Packages from dd01140 to 87a7c51 (2 revisions) (flutter/flutter#147539) 2024-04-29 [email protected] Roll Flutter Engine from 399837d38807 to 5165c711771c (2 revisions) (flutter/flutter#147537) 2024-04-29 [email protected] [Fix]: showDateRangePicker with "large" helpText cutoffs the save button (flutter/flutter#146049) 2024-04-29 [email protected] Roll Flutter Engine from 752b146df767 to 399837d38807 (10 revisions) (flutter/flutter#147532) 2024-04-29 [email protected] Add ability to disable `FloatingActionButton` scale and rotation animations using `FloatingActionButtonAnimator.noAnimation` (flutter/flutter#146126) 2024-04-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) (#147495)" (flutter/flutter#147502) 2024-04-28 [email protected] Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) (flutter/flutter#147495) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er#146403)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Apr 7, 2024

Amir-P force-pushed the feat/add_hit_test_behavior_to_scrollable branch from 9c8cc9e to 2a5598c Compare April 8, 2024 07:09

Piinks reviewed Apr 8, 2024

View reviewed changes

packages/flutter/test/widgets/scrollable_test.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/widgets/scroll_view.dart Outdated Show resolved Hide resolved

Piinks reviewed Apr 8, 2024

View reviewed changes

Amir-P force-pushed the feat/add_hit_test_behavior_to_scrollable branch from 2a5598c to 556270f Compare April 9, 2024 06:36

Amir-P requested a review from Piinks April 9, 2024 07:02

Piinks reviewed Apr 17, 2024

View reviewed changes

Amir-P and others added 5 commits April 19, 2024 12:10

Add configurable hitTestBehavior to Scrollable

6a92f1d

Format

9a9eb49

Add test for tap on Scrollable with translucent behavior

1520c9a

Update packages/flutter/lib/src/widgets/scrollable.dart

0b28763

Co-authored-by: Kate Lovett <[email protected]>

Update packages/flutter/test/widgets/scrollable_test.dart

0658329

Co-authored-by: Kate Lovett <[email protected]>

Amir-P force-pushed the feat/add_hit_test_behavior_to_scrollable branch from 4377ffd to 0658329 Compare April 19, 2024 08:40

Add hitTestBehavior to other Scrollable widgets

541774b

Amir-P requested a review from Piinks April 19, 2024 11:01

Format page_view.dart

c1bbb73

Piinks approved these changes Apr 29, 2024

View reviewed changes

chunhtai approved these changes Apr 29, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2024

auto-submit bot merged commit b176bce into flutter:master Apr 29, 2024

engine-flutter-autoroll mentioned this pull request Apr 30, 2024

Roll Flutter from db8c475cac11 to 12ad41ca9e43 (20 revisions) flutter/packages#6628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2024

b176bce Add configurable hitTestBehavior to Scrollable (flutter/flutt…

e430a16

…er#146403)

engine-flutter-autoroll mentioned this pull request Apr 30, 2024

Roll Flutter from db8c475cac11 to 456f0101fd26 (22 revisions) flutter/packages#6630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2024

b176bce Add configurable hitTestBehavior to Scrollable (flutter/flutt…

adc27c7

…er#146403)

engine-flutter-autoroll mentioned this pull request Apr 30, 2024

Roll Flutter from db8c475cac11 to b597dd24cb97 (23 revisions) flutter/packages#6631

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2024

b176bce Add configurable hitTestBehavior to Scrollable (flutter/flutt…

bd5982f

…er#146403)

Piinks mentioned this pull request May 3, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Amir-P deleted the feat/add_hit_test_behavior_to_scrollable branch May 7, 2024 06:09

moffatman mentioned this pull request May 12, 2024

GestureDetector does not detect tap when it is attached to child visually behind another child in Stack. #148192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

b176bce Add configurable hitTestBehavior to Scrollable (flutter/flutt…

012e394

…er#146403)

Add configurable hitTestBehavior to Scrollable #146403

Add configurable hitTestBehavior to Scrollable #146403

Uh oh!

Conversation

Amir-P commented Apr 7, 2024

Pre-launch Checklist

Uh oh!

moffatman commented Apr 7, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Piinks commented Apr 8, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Amir-P commented Apr 8, 2024

Uh oh!

Michal-MK commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Amir-P commented Apr 9, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Amir-P commented Apr 19, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Michal-MK commented Apr 8, 2024 •

edited

Loading