Fix DropdownButtonFormField throws when onChange is null #146342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Renzo-Olivares
approved these changes
Apr 8, 2024
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Renzo-Olivares
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 9, 2024
flutter/flutter@533d04d...4967a94 2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430) 2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477) 2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475) 2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468) 2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463) 2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449) 2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019) 2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342) 2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447) 2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445) 2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444) 2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Will this be patched to 3.19 as well? We've just completed our 3.16 upgrade in our previous release and see this issue in production. Our next release aims to release with 3.19. |
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
) ## Description This PRs fixes a null pointer exception thrown when reset is called on a `DropdownButtonFormField` whose `onChange` callback is null. ## Related Issue Fixes flutter#146335 ## Tests Adds 1 tests.
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@533d04d...4967a94 2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430) 2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477) 2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475) 2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468) 2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463) 2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449) 2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019) 2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342) 2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447) 2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445) 2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444) 2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs fixes a null pointer exception thrown when reset is called on a
DropdownButtonFormFieldwhoseonChangecallback is null.Related Issue
Fixes #146335
Tests
Adds 1 tests.