Fix frozen StretchingOverscrollIndicator animation
#146280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
Piinks
reviewed
Apr 16, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @gilnobrega thanks for contributing!
Piinks
approved these changes
Apr 17, 2024
chunhtai
approved these changes
Apr 17, 2024
| _stretchSizeTween.begin = _stretchSize.value; | ||
| _stretchSizeTween.end = math.min(_stretchIntensity + (_flingFriction / velocity), 1.0); | ||
| _stretchController.duration = Duration(milliseconds: (velocity * 0.02).round()); | ||
| _stretchController.duration = Duration(milliseconds: math.max(velocity * 0.02, 50).round()); |
Contributor
There was a problem hiding this comment.
we should probably define a const in this file
something like
const double _kMinStretchDuration = 50;
Contributor
Author
There was a problem hiding this comment.
I created constants for the minimum and maximum values of velocity and the minimum stretch duration.
I opted not to name them starting with a k prefix because other constants in the class do not have it, and they are not global constants.
Contributor
Author
|
Hello @Piinks can you investigate why |
Contributor
|
I checked the Google testing failure, it is expected as some customers had screenshots capturing that extremely stretched state it could get into. I have resolved those. |
…lutter#146325) flutter/engine@1fa0623...597d33f 2024-04-05 [email protected] Roll Skia from 22ba9c040aa2 to 5a9d7e508e41 (1 revision) (flutter/engine#51933) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146327) flutter/engine@597d33f...23a1d0d 2024-04-05 [email protected] Roll Skia from 5a9d7e508e41 to b1a37c7f4c75 (1 revision) (flutter/engine#51934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146330) flutter/engine@23a1d0d...292c48b 2024-04-05 [email protected] Roll Skia from b1a37c7f4c75 to f8977f658b66 (2 revisions) (flutter/engine#51935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
…lutter#146343) flutter/engine@292c48b...95ffe73 2024-04-05 [email protected] Roll Skia from f8977f658b66 to b3c27bb2d739 (1 revision) (flutter/engine#51936) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@dce6f0c...764d997 2024-04-05 [email protected] [video_player] Call `super.dispose` last in README example (flutter/packages#6051) 2024-04-04 [email protected] Fix macos_platform_tests package build times out when built for all packages (flutter/packages#6463) 2024-04-04 [email protected] Redistribute CODEOWNERS (flutter/packages#6457) 2024-04-04 [email protected] Roll Flutter from e868e2b to ac2ca93 (25 revisions) (flutter/packages#6460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
…lutter#146350) flutter/engine@95ffe73...6974dba 2024-04-05 [email protected] [et] Fixup help text a bit (flutter/engine#51930) 2024-04-05 [email protected] Roll Skia from b3c27bb2d739 to 6d673cafb8d1 (1 revision) (flutter/engine#51937) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146355) flutter/engine@6974dba...d048b9a 2024-04-05 [email protected] [Impeller] batch up filter graph command buffers. (flutter/engine#51912) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Relands flutter#146181. Just 3 commits: 1. a revert of the revert 2. the fix described in flutter#146181 (comment) 3. updating two postsubmit tests from Java 11 to 17, as that is required for this new AGP version. I've verified that `flutter build apk --flavor paid --debug` fails in `dev/integration_tests/flavors/` with the error in ci without (2), and succeeds with it. I've also verified that the `dev/benchmarks/complex_layout` app builds successfully with Java 17. That covers all the postsubmits that failed according [to the dashboard](https://flutter-dashboard.appspot.com/#/build).
…lutter#146357) flutter/engine@d048b9a...62df3bd 2024-04-05 [email protected] [Impeller] fail CI if validations are enabled but not available. (flutter/engine#51378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
…lutter#146360) flutter/engine@62df3bd...6a478d6 2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove #if SHELL_ENABLE_METAL checks in iOS code (flutter#51636)" (flutter/engine#51941) 2024-04-05 [email protected] Roll Fuchsia Linux SDK from TAr6MCirveGvhZFHK... to EaKtmpePocJx6qaKg... (flutter/engine#51940) 2024-04-05 [email protected] Roll Skia from 6d673cafb8d1 to 0424e59d3a08 (1 revision) (flutter/engine#51939) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from TAr6MCirveGv to EaKtmpePocJx If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146364) flutter/engine@6a478d6...da995a1 2024-04-05 [email protected] [Impeller] reland foreground blend optimizaiton, fix advanced blend optimization. (flutter/engine#51938) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146366) flutter/engine@da995a1...48604df 2024-04-05 [email protected] Adds human readable descriptions to build configs (flutter/engine#51929) 2024-04-05 [email protected] Roll Skia from 0424e59d3a08 to d596d9e4cb4f (1 revision) (flutter/engine#51942) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.9 to 3.24.10. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>3.24.10 - 05 Apr 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.0. <a href="https://redirect.github.com/github/codeql-action/pull/2219">#2219</a></li> <li>Add a deprecation warning for customers using CodeQL version 2.12.5 and earlier. These versions of CodeQL were discontinued on 26 March 2024 alongside GitHub Enterprise Server 3.8, and will be unsupported by CodeQL Action versions 3.25.0 and later and versions 2.25.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2220">#2220</a> <ul> <li>If you are using one of these versions, please update to CodeQL CLI version 2.12.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li> <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.11.6 and 2.12.5, you can replace <code>github/codeql-action/*@V3</code> by <code>github/codeql-action/*@v3.24.10</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.24.10</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li> </ul> </li> </ul> <h2>3.24.9 - 22 Mar 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li> </ul> <h2>3.24.8 - 18 Mar 2024</h2> <ul> <li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li> </ul> <h2>3.24.7 - 12 Mar 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li> </ul> <h2>3.24.6 - 29 Feb 2024</h2> <p>No user facing changes.</p> <h2>3.24.5 - 23 Feb 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li> </ul> <h2>3.24.4 - 21 Feb 2024</h2> <ul> <li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li> </ul> <h2>3.24.3 - 15 Feb 2024</h2> <ul> <li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li> </ul> <h2>3.24.2 - 15 Feb 2024</h2> <ul> <li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li> </ul> <h2>3.24.1 - 13 Feb 2024</h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/4355270be187e1b672a7a1c7c7bae5afdc1ab94a"><code>4355270</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2226">#2226</a> from github/update-v3.24.10-7df281f2f</li> <li><a href="https://github.com/github/codeql-action/commit/3f041c51a5d00e36a4ea25ed1c14d851d65db7cb"><code>3f041c5</code></a> Update changelog for v3.24.10</li> <li><a href="https://github.com/github/codeql-action/commit/7df281f2feac4aa04424a4fcca3efb7f7c9f681f"><code>7df281f</code></a> Gracefully continue if <code>createStatusReportBase</code> throws (<a href="https://redirect.github.com/github/codeql-action/issues/2225">#2225</a>)</li> <li><a href="https://github.com/github/codeql-action/commit/f421cda8e715cc7652d8b748f49574cf286aec12"><code>f421cda</code></a> Run integration test PR checks nightly (<a href="https://redirect.github.com/github/codeql-action/issues/2222">#2222</a>)</li> <li><a href="https://github.com/github/codeql-action/commit/5f535debfea657d84f956486f01539ccb5330f43"><code>5f535de</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2221">#2221</a> from github/nickfyson/upload-logging</li> <li><a href="https://github.com/github/codeql-action/commit/278465cdfb754d68191bff6702d925c85eeb2a55"><code>278465c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2219">#2219</a> from github/update-bundle/codeql-bundle-v2.17.0</li> <li><a href="https://github.com/github/codeql-action/commit/65e69c8a4b476ce903dc9795a65db719486a0d92"><code>65e69c8</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.17.0</li> <li><a href="https://github.com/github/codeql-action/commit/c037115ddf761460364e7a6fddfe05adb9dfc4a6"><code>c037115</code></a> clarify logging in response to pr review comments</li> <li><a href="https://github.com/github/codeql-action/commit/d3c32a84cb5364893701e6664feb83986c420052"><code>d3c32a8</code></a> fix test to respect updated logging behaviour</li> <li><a href="https://github.com/github/codeql-action/commit/26540626a59343078de93e8aedf34b4ae8d876ef"><code>2654062</code></a> Merge branch 'main' into nickfyson/upload-logging</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/1b1aada464948af03b950897e5eb522f92603cc2...4355270be187e1b672a7a1c7c7bae5afdc1ab94a">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…lutter#146370) flutter/engine@48604df...b503915 2024-04-05 [email protected] Roll Skia from d596d9e4cb4f to d0f229153ae7 (2 revisions) (flutter/engine#51946) 2024-04-05 [email protected] [Impeller] handle fill polylines with zero area. (flutter/engine#51945) 2024-04-05 [email protected] [Windows] Move EGL surface creation (flutter/engine#51920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is part 8 of a broken down version of the flutter#140101 refactor. This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies. This particular change attempts to be minimal. A future change will apply some formatting cleanup (newlines, reordering parameters and arguments) for clarity.
…lutter#146373) flutter/engine@b503915...df9f743 2024-04-05 [email protected] Roll Skia from d0f229153ae7 to 98601d1c3ff4 (2 revisions) (flutter/engine#51949) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146377) flutter/engine@df9f743...b0d7ac5 2024-04-05 [email protected] Fix a memory error in a multithreaded test (flutter/engine#51951) 2024-04-05 [email protected] Roll Skia from 98601d1c3ff4 to 46e7fea48565 (1 revision) (flutter/engine#51950) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146382) flutter/engine@b0d7ac5...482172d 2024-04-06 [email protected] Roll Skia from 46e7fea48565 to 190396c73578 (1 revision) (flutter/engine#51953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@88a3a56...01a32c4 2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587) 2024-04-21 [email protected] Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter/packages#6583) 2024-04-19 [email protected] [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874) 2024-04-19 [email protected] Roll Flutter from fb110b9 to 98685a0 (28 revisions) (flutter/packages#6577) 2024-04-19 [email protected] Roll Flutter (stable) from 300451a to 54e6646 (1 revision) (flutter/packages#6575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
From flutter#143348 (comment): > before we ship, we should add a printTrace to the tool about each asset transformer we're invoking and the path/arguments we called it with I think this is a good idea since asset transformers can be arbitrary Dart programs�meaning that a lot can go wrong when running them. For example, they can hang indefinitely or perform some sort of I/O that later results in a tool crash. Knowing that asset transformation was involved when debugging a crash (or a slow/stuck `flutter build`) could be useful, so I think adding a `printTrace` or two is a good idea (or at least not a bad one).
Here's another PR with a couple of typos fixed. As you can see there was a typo in _fileReferenceI**n**dentifiers_, in class _ParsedProjectInfo._ Maybe we should do some check on that since I'm not sure if that property is used somewhere outside Flutter?
In the `examples/api`, the Android platform missed this step while migrating to the declarative plugins {} block described in [flutter-gradle-plugin-apply](https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply), so all examples of `examples/api` cannot run.
Fixes flutter#147100
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
…lutter#147175) flutter/engine@75ca219...a4b71f0 2024-04-21 [email protected] Roll Dart SDK from d4c5d9c92e4d to 0a83dd7e61b1 (1 revision) (flutter/engine#52291) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
github-actions
bot
added
a: tests
9 tasks
gilnobrega
deleted the
fix-stretchingoverscrollindicator-frozen-animation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StretchingOverscrollIndicator's controller does not have a minimum value for its animation duration.When the
OverscrollNotification'svelocityis small enough (<25) the controller'sabsorbImpactmethod sets this animation duration to 0ms, making the animation appear frozen to the user.This PR sets a minimum animation duration of 1ms.
Fixes #146277
Screen.Recording.2024-04-04.at.16.07.43.mov
Screen.Recording.2024-04-04.at.16.34.17.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.