[tools] Fix --template=plugin_ffi formatting
#146269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
liamappelbe
approved these changes
Apr 4, 2024
dcharkes
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 11, 2024
flutter/flutter@97cd47a...557fbf5 2024-04-11 [email protected] Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604) 2024-04-11 [email protected] Fix out of sync templates files and add a check (flutter/flutter#145747) 2024-04-11 [email protected] [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269) 2024-04-11 [email protected] Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622) 2024-04-11 [email protected] Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621) 2024-04-11 [email protected] Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567) 2024-04-11 [email protected] Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619) 2024-04-11 [email protected] Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618) 2024-04-11 [email protected] Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617) 2024-04-11 [email protected] Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613) 2024-04-11 [email protected] Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611) 2024-04-11 [email protected] Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609) 2024-04-10 [email protected] Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607) 2024-04-10 [email protected] Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534) 2024-04-10 [email protected] Roll pub packages (flutter/flutter#146606) 2024-04-10 [email protected] Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605) 2024-04-10 [email protected] Remove additional references to engine v1 android embedding (flutter/flutter#146523) 2024-04-10 [email protected] Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591) 2024-04-10 [email protected] Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585) 2024-04-10 [email protected] Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537) 2024-04-10 [email protected] Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577) 2024-04-10 [email protected] Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (flutter/flutter#146575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
It looks like the formatter was updated. We have a test running on the FFIgen repo that checks that rerunning the generated bindings with FFIgen generates identical bindings. Closes: * dart-lang/native#1072
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@97cd47a...557fbf5 2024-04-11 [email protected] Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604) 2024-04-11 [email protected] Fix out of sync templates files and add a check (flutter/flutter#145747) 2024-04-11 [email protected] [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269) 2024-04-11 [email protected] Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622) 2024-04-11 [email protected] Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621) 2024-04-11 [email protected] Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567) 2024-04-11 [email protected] Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619) 2024-04-11 [email protected] Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618) 2024-04-11 [email protected] Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617) 2024-04-11 [email protected] Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613) 2024-04-11 [email protected] Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611) 2024-04-11 [email protected] Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609) 2024-04-10 [email protected] Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607) 2024-04-10 [email protected] Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534) 2024-04-10 [email protected] Roll pub packages (flutter/flutter#146606) 2024-04-10 [email protected] Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605) 2024-04-10 [email protected] Remove additional references to engine v1 android embedding (flutter/flutter#146523) 2024-04-10 [email protected] Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591) 2024-04-10 [email protected] Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585) 2024-04-10 [email protected] Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537) 2024-04-10 [email protected] Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577) 2024-04-10 [email protected] Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (flutter/flutter#146575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the formatter was updated.
We have a test running on the FFIgen repo that checks that rerunning the generated bindings with FFIgen generates identical bindings.
Closes: