Refactor tool tests #146217
Refactor tool tests #146217
Conversation
|
Holding this as a draft since it relies on the refactoring of |
sealesj
added
the
autosubmit
|
auto label is removed for flutter/flutter/146217, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
|
||
| import '../utils.dart'; | ||
|
|
||
| Future<void> toolTestsRunner() async { |
There was a problem hiding this comment.
Was there a particular reason the tool integration tests are not here?
There was a problem hiding this comment.
I can create a suite for all those tool tests to be included if that would make more sense
There was a problem hiding this comment.
I'm not sure what that means. How much work does "creating a suite" entail? Although I suppose this was in its own function in test.dart. I suspect that was accidental, rather than intentional.
From a purely organizational perspective, I would weakly prefer that all the test functions that invoke test directories under //flutter/packages/flutter_tools/test be grouped together in the same library (dart's terminology for a file). But if that's a lot of work to implement I'm open to discussion.
3 participants
Refactor tool tests suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing tool tests tests
Part of #145482
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.