computeDryBaseline for rendering / widgets RenderBoxes
#146143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
LongCatIsLooong
force-pushed
the
rendering-widgets-drybaseline
branch
from
a117d65 to
beb2220
Compare
goderbauer
reviewed
Apr 3, 2024
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
Are the google testing failures anything to worry about?
| /// for each child managed by the [ContainerRenderObjectMixin] mixin. | ||
| /// | ||
| /// The `getChildBaseline` parameter and the `layoutChild` parameter must be | ||
| /// consistent: `isDryLayout` must be set to true, if `layoutChild` computes |
Member
There was a problem hiding this comment.
What does isDryLayout refer to here?
Contributor
Author
No I think those are build failures. It's because this depends on the material render box PR (the |
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 4, 2024
flutter/flutter@e868e2b...ac2ca93 2024-04-04 [email protected] Roll Flutter Engine from aadf522e3c98 to 4303dc0d7a73 (1 revision) (flutter/flutter#146262) 2024-04-04 [email protected] Roll Flutter Engine from c57c8665b4eb to aadf522e3c98 (1 revision) (flutter/flutter#146261) 2024-04-04 [email protected] Roll Flutter Engine from ca7596642cfd to c57c8665b4eb (1 revision) (flutter/flutter#146259) 2024-04-04 [email protected] Roll Flutter Engine from 83c037c449b5 to ca7596642cfd (1 revision) (flutter/flutter#146258) 2024-04-04 [email protected] Roll Flutter Engine from 614154012e93 to 83c037c449b5 (1 revision) (flutter/flutter#146255) 2024-04-04 [email protected] Roll Flutter Engine from 41da00ac46bc to 614154012e93 (1 revision) (flutter/flutter#146250) 2024-04-04 [email protected] Roll Flutter Engine from 18fdcad40332 to 41da00ac46bc (6 revisions) (flutter/flutter#146246) 2024-04-04 [email protected] Roll pub packages (flutter/flutter#146245) 2024-04-03 [email protected] Add tests for theme_extension.1.dart API example. (flutter/flutter#145819) 2024-04-03 [email protected] Roll Flutter Engine from 349608d2b008 to 18fdcad40332 (6 revisions) (flutter/flutter#146240) 2024-04-03 [email protected] Add `missing_code_block_language_in_doc_comment` lint. (flutter/flutter#145354) 2024-04-03 [email protected] Magnifier cleanup (flutter/flutter#143558) 2024-04-03 [email protected] Set up Kotlin linting step in ci with ktlint (flutter/flutter#143478) 2024-04-03 [email protected] Roll Flutter Engine from 1a9e48ab1c9a to 349608d2b008 (1 revision) (flutter/flutter#146230) 2024-04-03 [email protected] Update ownership to GitHub handles (flutter/flutter#146221) 2024-04-03 [email protected] Roll Flutter Engine from d065763b1a63 to 1a9e48ab1c9a (1 revision) (flutter/flutter#146226) 2024-04-03 [email protected] Refactor fuchsia_precache (flutter/flutter#145978) 2024-04-03 [email protected] Roll Flutter Engine from b1c23addaec5 to d065763b1a63 (1 revision) (flutter/flutter#146218) 2024-04-03 [email protected] `computeDryBaseline` for rendering / widgets RenderBoxes (flutter/flutter#146143) 2024-04-03 [email protected] Roll Flutter Engine from 7b28ae1d15cb to b1c23addaec5 (1 revision) (flutter/flutter#146214) 2024-04-03 [email protected] Fix TextStyle.lerp() to properly interpolate text shadows (flutter/flutter#145666) 2024-04-03 [email protected] Renderflex cross intrinsic size with baseline alignment (flutter/flutter#146185) 2024-04-03 [email protected] Roll Flutter Engine from 56fa2c33a5f7 to 7b28ae1d15cb (1 revision) (flutter/flutter#146208) 2024-04-03 [email protected] Refactor customer_testing (flutter/flutter#145911) 2024-04-03 [email protected] Add `DropdownMenu` cursor behavior sample (flutter/flutter#146133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@e868e2b...ac2ca93 2024-04-04 [email protected] Roll Flutter Engine from aadf522e3c98 to 4303dc0d7a73 (1 revision) (flutter/flutter#146262) 2024-04-04 [email protected] Roll Flutter Engine from c57c8665b4eb to aadf522e3c98 (1 revision) (flutter/flutter#146261) 2024-04-04 [email protected] Roll Flutter Engine from ca7596642cfd to c57c8665b4eb (1 revision) (flutter/flutter#146259) 2024-04-04 [email protected] Roll Flutter Engine from 83c037c449b5 to ca7596642cfd (1 revision) (flutter/flutter#146258) 2024-04-04 [email protected] Roll Flutter Engine from 614154012e93 to 83c037c449b5 (1 revision) (flutter/flutter#146255) 2024-04-04 [email protected] Roll Flutter Engine from 41da00ac46bc to 614154012e93 (1 revision) (flutter/flutter#146250) 2024-04-04 [email protected] Roll Flutter Engine from 18fdcad40332 to 41da00ac46bc (6 revisions) (flutter/flutter#146246) 2024-04-04 [email protected] Roll pub packages (flutter/flutter#146245) 2024-04-03 [email protected] Add tests for theme_extension.1.dart API example. (flutter/flutter#145819) 2024-04-03 [email protected] Roll Flutter Engine from 349608d2b008 to 18fdcad40332 (6 revisions) (flutter/flutter#146240) 2024-04-03 [email protected] Add `missing_code_block_language_in_doc_comment` lint. (flutter/flutter#145354) 2024-04-03 [email protected] Magnifier cleanup (flutter/flutter#143558) 2024-04-03 [email protected] Set up Kotlin linting step in ci with ktlint (flutter/flutter#143478) 2024-04-03 [email protected] Roll Flutter Engine from 1a9e48ab1c9a to 349608d2b008 (1 revision) (flutter/flutter#146230) 2024-04-03 [email protected] Update ownership to GitHub handles (flutter/flutter#146221) 2024-04-03 [email protected] Roll Flutter Engine from d065763b1a63 to 1a9e48ab1c9a (1 revision) (flutter/flutter#146226) 2024-04-03 [email protected] Refactor fuchsia_precache (flutter/flutter#145978) 2024-04-03 [email protected] Roll Flutter Engine from b1c23addaec5 to d065763b1a63 (1 revision) (flutter/flutter#146218) 2024-04-03 [email protected] `computeDryBaseline` for rendering / widgets RenderBoxes (flutter/flutter#146143) 2024-04-03 [email protected] Roll Flutter Engine from 7b28ae1d15cb to b1c23addaec5 (1 revision) (flutter/flutter#146214) 2024-04-03 [email protected] Fix TextStyle.lerp() to properly interpolate text shadows (flutter/flutter#145666) 2024-04-03 [email protected] Renderflex cross intrinsic size with baseline alignment (flutter/flutter#146185) 2024-04-03 [email protected] Roll Flutter Engine from 56fa2c33a5f7 to 7b28ae1d15cb (1 revision) (flutter/flutter#146208) 2024-04-03 [email protected] Refactor customer_testing (flutter/flutter#145911) 2024-04-03 [email protected] Add `DropdownMenu` cursor behavior sample (flutter/flutter#146133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderWrap, Table, Overlay / Stack are not included
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.