Reverts "Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) (#146100)" #146106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
approved these changes
Apr 1, 2024
auto-submit
bot
deleted the
revert_7fa932be5c12437eddc08915fe3d9ee1bbda57f2
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 2, 2024
…2 (3 revisions) (#146100)" (flutter/flutter#146106)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 2, 2024
flutter/flutter@7fa932b...a418568 2024-04-02 [email protected] Roll Flutter Engine from decca6b8bf45 to 523fc953ebc8 (1 revision) (flutter/flutter#146118) 2024-04-02 [email protected] Roll Flutter Engine from 370e325098fb to decca6b8bf45 (1 revision) (flutter/flutter#146111) 2024-04-02 [email protected] Roll Flutter Engine from 9a513de65251 to 370e325098fb (1 revision) (flutter/flutter#146109) 2024-04-02 [email protected] Manual roll Flutter Engine from e6f19409b613 to 9a513de65251 (12 revisions) (flutter/flutter#146108) 2024-04-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) (#146100)" (flutter/flutter#146106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@7fa932b...a418568 2024-04-02 [email protected] Roll Flutter Engine from decca6b8bf45 to 523fc953ebc8 (1 revision) (flutter/flutter#146118) 2024-04-02 [email protected] Roll Flutter Engine from 370e325098fb to decca6b8bf45 (1 revision) (flutter/flutter#146111) 2024-04-02 [email protected] Roll Flutter Engine from 9a513de65251 to 370e325098fb (1 revision) (flutter/flutter#146109) 2024-04-02 [email protected] Manual roll Flutter Engine from e6f19409b613 to 9a513de65251 (12 revisions) (flutter/flutter#146108) 2024-04-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) (#146100)" (flutter/flutter#146106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #146100
Initiated by: LongCatIsLooong
Reason for reverting: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3118/overview
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
flutter/engine@e6f1940...ea93c5d
2024-04-01 [email protected] [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269)
2024-04-01 [email protected] Remove
testing/android_background_imagewhich does not run/exist on CI. (flutter/engine#51815)2024-04-01 [email protected] [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md