Skip to content

Revert "Reduce noise in xcodebuild stdout" #14605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xster merged 1 commit into from
Feb 9, 2018
Merged

Revert "Reduce noise in xcodebuild stdout" #14605

xster merged 1 commit into from
Feb 9, 2018

Conversation

@xster
Copy link
Member

@xster xster commented Feb 9, 2018

Breaks device lab. There's some unwanted concurrency somewhere in there but I can't figure out where.

Reverts #14586

goderbauer
goderbauer approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster
Copy link
Member Author

xster commented Feb 9, 2018

Submitting on red to unbreak head.

Not sure why it's referring to #14602 since it's not affecting that file.

@xster xster force-pushed the revert-14586-xcode-stdout-cleanup-1 branch from b96a56b to 2afe35b Compare February 9, 2018 22:27
@xster
Copy link
Member Author

xster commented Feb 9, 2018

Rebased to get rid of the #14602 reference.

@xster xster merged commit 8e2278b into master Feb 9, 2018
@xster xster deleted the revert-14586-xcode-stdout-cleanup-1 branch February 9, 2018 22:28
xster added a commit to xster/flutter that referenced this pull request Feb 10, 2018
@xster
Revert "Revert "Reduce noise in xcodebuild stdout (flutter#14586)" (f…
9a30a15 
…lutter#14605)"

This reverts commit 8e2278b.
xster added a commit that referenced this pull request Feb 11, 2018
@xster
Reduce xcodebuild noise #2 (#14622)
33ea7f8 
* Revert "Revert "Reduce noise in xcodebuild stdout (#14586)" (#14605)"

This reverts commit 8e2278b.

* Specify the build config when cleaning
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@xster
Revert "Reduce noise in xcodebuild stdout (flutter#14586)" (flutter#1…
bb4e7b6 
…4605)

This reverts commit 74ddda5.
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@xster
Reduce xcodebuild noise flutter#2 (flutter#14622)
a63fff8 
* Revert "Revert "Reduce noise in xcodebuild stdout (flutter#14586)" (flutter#14605)"

This reverts commit 8e2278b.

* Specify the build config when cleaning
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xster @goderbauer @googlebot