Implement computeDryBaseline for cupertino RenderBoxes
#145951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
goderbauer
approved these changes
Mar 29, 2024
| bool get isAbove => anchorAbove.dy >= (child?.size.height ?? 0.0) - _kToolbarArrowSize.height * 2; | ||
|
|
||
| Offset _computeChildOffset(Size childSize) { | ||
| final bool isAbove = anchorAbove.dy >= childSize.height - _kToolbarArrowSize.height * 2; |
Member
There was a problem hiding this comment.
Should we unify this line with the isAbove getter and turn that into a method that takes child size? Child size could default to child.size if not provided.
Comment on lines
292
to
294
| final BoxConstraints enforcedConstraint = BoxConstraints( | ||
| minWidth: _kToolbarArrowSize.width + _kToolbarBorderRadius.x * 2, | ||
| ).enforce(constraints.loosen()); |
Member
There was a problem hiding this comment.
Also wondering if we should deduplicate this with performLayout and have a method that gives us the child constraints based on provided constraints?
…lutter into cupertino-dry-baseline
LongCatIsLooong
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/145951, due to - The status or check suite Windows build_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2024
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 1, 2024
flutter/flutter@d12ba5c...9d32f07 2024-03-31 [email protected] Roll Flutter Engine from 2decefb00d1e to 34081fea4d59 (1 revision) (flutter/flutter#146048) 2024-03-31 [email protected] Roll Flutter Engine from 3588d31a98f6 to 2decefb00d1e (1 revision) (flutter/flutter#146047) 2024-03-30 [email protected] Implement `computeDryBaseline` for cupertino `RenderBox`es (flutter/flutter#145951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@d12ba5c...9d32f07 2024-03-31 [email protected] Roll Flutter Engine from 2decefb00d1e to 34081fea4d59 (1 revision) (flutter/flutter#146048) 2024-03-31 [email protected] Roll Flutter Engine from 3588d31a98f6 to 2decefb00d1e (1 revision) (flutter/flutter#146047) 2024-03-30 [email protected] Implement `computeDryBaseline` for cupertino `RenderBox`es (flutter/flutter#145951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_debugVerifyDryBaselinesmethod verifies that dry baseline implementation is consistent with the wet baseline method at the current constraints.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.