Skip to content

Conversation

@polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 28, 2024
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145940, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145940, due to - The status or check suite Windows tool_integration_tests_3_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 29, 2024

auto label is removed for flutter/flutter/145940, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit auto-submit bot merged commit 1a2f34a into flutter:master Mar 29, 2024
@polina-c polina-c deleted the upgrade-lt branch March 29, 2024 02:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 29, 2024
flutter/flutter@89ea492...8528881

2024-03-29 [email protected] Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718)
2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145940)
2024-03-29 [email protected] Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946)
2024-03-29 [email protected] Refactor flutter_plugins (flutter/flutter#145870)
2024-03-29 [email protected] Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936)
2024-03-29 [email protected] Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941)
2024-03-28 [email protected] Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938)
2024-03-28 [email protected] `RenderFlex` baseline intrinsics (flutter/flutter#145483)
2024-03-28 [email protected] Use reporter extended consistently. (flutter/flutter#145617)
2024-03-28 [email protected] Update tokens to v2.3.5 (flutter/flutter#145356)
2024-03-28 [email protected] Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants