-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Refactor flutter_plugins #145870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flutter_plugins #145870
Conversation
| final Directory checkout = Directory.systemTemp.createTempSync('flutter_packages.'); | ||
| await runCommand( | ||
| 'git', | ||
| <String>[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit const
| final String toolDir = path.join(checkout.path, 'script', 'tool'); | ||
| await runCommand( | ||
| 'dart', | ||
| <String>[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit const
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
auto label is removed for flutter/flutter/145870, due to Pull request flutter/flutter/145870 is not in a mergeable state. |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter@89ea492...8528881 2024-03-29 [email protected] Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 [email protected] Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 [email protected] Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 [email protected] Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 [email protected] Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 [email protected] Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 [email protected] `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 [email protected] Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 [email protected] Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 [email protected] Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Refactor flutter_plugins suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing flutter_plugins tests
Also update the test_test invocation of getFlutterPackagesVersion
Part of #145482
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.