Skip to content

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented Mar 28, 2024

Refactor flutter_plugins suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing flutter_plugins tests

Also update the test_test invocation of getFlutterPackagesVersion

Part of #145482

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj added the team-infra Owned by Infrastructure team label Mar 28, 2024
@sealesj sealesj self-assigned this Mar 28, 2024
@sealesj sealesj marked this pull request as ready for review March 28, 2024 16:17
final Directory checkout = Directory.systemTemp.createTempSync('flutter_packages.');
await runCommand(
'git',
<String>[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit const

final String toolDir = path.join(checkout.path, 'script', 'tool');
await runCommand(
'dart',
<String>[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit const

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145870, due to Pull request flutter/flutter/145870 is not in a mergeable state.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit auto-submit bot merged commit 93b071e into flutter:master Mar 29, 2024
@sealesj sealesj deleted the refactor_flutter_plugins_tests branch March 29, 2024 01:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 29, 2024
flutter/flutter@89ea492...8528881

2024-03-29 [email protected] Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718)
2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145940)
2024-03-29 [email protected] Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946)
2024-03-29 [email protected] Refactor flutter_plugins (flutter/flutter#145870)
2024-03-29 [email protected] Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936)
2024-03-29 [email protected] Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941)
2024-03-28 [email protected] Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938)
2024-03-28 [email protected] `RenderFlex` baseline intrinsics (flutter/flutter#145483)
2024-03-28 [email protected] Use reporter extended consistently. (flutter/flutter#145617)
2024-03-28 [email protected] Update tokens to v2.3.5 (flutter/flutter#145356)
2024-03-28 [email protected] Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants