Disable selection of the Android ARM64 target platform based on the attached device #14581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttached device The current ARM64 back end generates code that crashes on some devices, including Pixel phones. With this change, the android-arm64 target will not be used by "flutter run" unless explicitly requested. This is intended as a workaround until we can roll out an engine with the required Dart VM fix. See flutter#14454
aam
approved these changes
Feb 8, 2018
srawlins
added a commit
to srawlins/flutter
that referenced
this pull request
Feb 9, 2018
* master: (88 commits) Upgrade dartdoc to 0.16.0. (flutter#14602) Reduce noise in xcodebuild stdout (flutter#14586) Add annotations to ignore analyzer errors on pre-dev.22 SDKs (flutter#14599) Roll engine to 337764e (flutter#14597) Roll engine with rolled dart (flutter#14538) Upgrade packages (flutter#14588) Change GlobalObjectKey.toString to strip away State<StatefulWidget>. (flutter#14558) Disable selection of the Android ARM64 target platform based on the attached device (flutter#14581) Add a flutter run option that can override the default target platform (flutter#14537) Fix message channel usage in few tests. (flutter#14557) Update documentation on how to test flutter_tools (flutter#14567) Fix text_style_text.dart to be Dart 2 compliant. (flutter#14559) Hide the NDK warning that should never happen with a regexp (flutter#14503) Fix iOS build which broke after the change to fuse --strong option into --preview-dart-2. Mark run_machine_concurrent_hot_reload as flaky (flutter#14563) Fuse --strong into --preview-dart-2 option. Partially fix Dart 2 issues in animated_icons.test. (flutter#14531) Strong mode fixes in tests (flutter#14520) Fix typo. Fix issues. ...
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…ttached device (flutter#14581) The current ARM64 back end generates code that crashes on some devices, including Pixel phones. With this change, the android-arm64 target will not be used by "flutter run" unless explicitly requested. This is intended as a workaround until we can roll out an engine with the required Dart VM fix. See flutter#14454
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ARM64 back end generates code that crashes on some devices,
including Pixel phones. With this change, the android-arm64 target will
not be used by "flutter run" unless explicitly requested.
This is intended as a workaround until we can roll out an engine with the
required Dart VM fix.
See #14454