Remove trailing commas in android dependency version checking gradle plugin #145718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
For reference: What's new in Kotlin 1.4 |
reidbaker
approved these changes
Mar 29, 2024
Contributor
|
@gmackall what do we currently have as the minimum supported version of kotlin? |
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 29, 2024
flutter/flutter@89ea492...8528881 2024-03-29 [email protected] Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 [email protected] Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 [email protected] Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 [email protected] Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 [email protected] Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 [email protected] Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 [email protected] `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 [email protected] Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 [email protected] Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 [email protected] Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
Author
We currently warn for below 1.5, and don't error for any version |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
Adds a kotlin linting step to the linux analyze check, using a version of [ktlint](https://github.com/pinterest/ktlint) hosted on [CIPD](https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64/+/version_1_1_1). Configured to disallow trailing commas, because of (and now acting as a test for) #145718. Because of this configuration the PR also removes some trailing commas in some kotlin files. Also checks in a baseline file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently old versions of kotlin (pre 1.4) don't allow trailing commas.
Example logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752506486861217537/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.