Fix disabled `DropdownMenu` doesn't defer the mouse cursor #145686

TahaTesser · 2024-03-25T14:19:04Z

fixes DropdownMenu cursor in disabled state

This was added in #121353

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisSize: MainAxisSize.min,
            children: <Widget>[
              const Spacer(),
              const Text('enabled: true,\nrequestFocusOnTap: true,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: true,
                initialSelection: 'First',
                requestFocusOnTap: true,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: text cursor'),
              const Spacer(),
              const Text('enabled: true,\nrequestFocusOnTap: false,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: true,
                initialSelection: 'First',
                requestFocusOnTap: false,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
                // label: const Text('requestFocusOnTap: false'),
              ),
              const Text('Expected: clickable cursor'),
              const Spacer(),
              const Text('enabled: false,\nrequestFocusOnTap: true,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: false,
                initialSelection: 'First',
                requestFocusOnTap: true,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: deferred cursor'),
              const Spacer(),
              const Text('enabled: false,\nrequestFocusOnTap: false,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: false,
                initialSelection: 'First',
                requestFocusOnTap: false,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: deferred cursor'),
              const Spacer(),
            ],
          ),
        ),
      ),
    );
  }
}

Preview

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc

LGTM:)

…lutter/flutter#145686)

Manual roll Flutter from dbdcead to 89ea492 (54 revisions) Manual roll requested by [email protected] flutter/flutter@dbdcead...89ea492 2024-03-28 [email protected] Roll Flutter Engine from f71e5ad8586b to a396dc1a03a9 (3 revisions) (flutter/flutter#145928) 2024-03-28 [email protected] Roll Flutter Engine from 043af350ae85 to f71e5ad8586b (1 revision) (flutter/flutter#145919) 2024-03-28 [email protected] Refactor skp_generator_tests (flutter/flutter#145871) 2024-03-28 [email protected] Roll Flutter Engine from 7c9d5adb6ff8 to 043af350ae85 (2 revisions) (flutter/flutter#145917) 2024-03-28 [email protected] Update `TabBar` and `TabBar.secondary` to use indicator height/color M3 tokens (flutter/flutter#145753) 2024-03-28 [email protected] Roll Packages from e6b3e11 to 924c7e6 (5 revisions) (flutter/flutter#145915) 2024-03-28 [email protected] Add `viewId` to `TextInputConfiguration` (flutter/flutter#145708) 2024-03-28 [email protected] Roll Flutter Engine from 9df2d3a0778e to 7c9d5adb6ff8 (3 revisions) (flutter/flutter#145909) 2024-03-28 [email protected] Manual roll Flutter Engine from c602abdbae16 to 9df2d3a0778e (10 revisions) (flutter/flutter#145903) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (#145877)" (flutter/flutter#145901) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (#145879)" (flutter/flutter#145900) 2024-03-28 [email protected] Roll Flutter Engine from 922c7b133bc2 to b3516c4c5683 (1 revision) (flutter/flutter#145879) 2024-03-28 [email protected] Roll Flutter Engine from c602abdbae16 to 922c7b133bc2 (7 revisions) (flutter/flutter#145877) 2024-03-28 [email protected] Remove deprecated `TextTheme` members (flutter/flutter#139255) 2024-03-27 [email protected] [WIP] Predictive back support for routes (flutter/flutter#141373) 2024-03-27 [email protected] Roll Flutter Engine from 73c145c9ac3a to c602abdbae16 (1 revision) (flutter/flutter#145865) 2024-03-27 [email protected] Roll Flutter Engine from d65662541682 to 73c145c9ac3a (8 revisions) (flutter/flutter#145862) 2024-03-27 [email protected] Roll Flutter Engine from b7dddee939f2 to d65662541682 (2 revisions) (flutter/flutter#145851) 2024-03-27 [email protected] Roll Flutter Engine from 00dab0d9d310 to b7dddee939f2 (2 revisions) (flutter/flutter#145841) 2024-03-27 [email protected] Roll Packages from ab1630b to e6b3e11 (6 revisions) (flutter/flutter#145833) 2024-03-27 [email protected] Refactor web long running tests (flutter/flutter#145776) 2024-03-27 [email protected] Roll Flutter Engine from da64c6bcbbb6 to 00dab0d9d310 (1 revision) (flutter/flutter#145830) 2024-03-27 [email protected] Roll Flutter Engine from d6c6ba5aa157 to da64c6bcbbb6 (1 revision) (flutter/flutter#145811) 2024-03-27 [email protected] Roll Flutter Engine from 064a4f5d9042 to d6c6ba5aa157 (1 revision) (flutter/flutter#145807) 2024-03-27 [email protected] Roll Flutter Engine from cad8e7a9ad70 to 064a4f5d9042 (1 revision) (flutter/flutter#145805) 2024-03-27 [email protected] Roll Flutter Engine from 441005698702 to cad8e7a9ad70 (1 revision) (flutter/flutter#145804) 2024-03-27 [email protected] Roll Flutter Engine from d872d50e53f4 to 441005698702 (1 revision) (flutter/flutter#145803) 2024-03-27 [email protected] Roll Flutter Engine from 92ebd47dd8a8 to d872d50e53f4 (6 revisions) (flutter/flutter#145801) 2024-03-27 [email protected] Update localization files. (flutter/flutter#145780) 2024-03-27 [email protected] Roll Flutter Engine from 026d8902e3b5 to 92ebd47dd8a8 (1 revision) (flutter/flutter#145788) 2024-03-26 [email protected] [web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. (flutter/flutter#145786) 2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.1.0 to 4.1.1 (flutter/flutter#145787) 2024-03-26 [email protected] Roll pub packages and regenerate gradle lockfiles (flutter/flutter#145727) 2024-03-26 [email protected] Roll Flutter Engine from 5c7aea6f20fc to 026d8902e3b5 (1 revision) (flutter/flutter#145785) 2024-03-26 [email protected] Roll Flutter Engine from baede78d2352 to 5c7aea6f20fc (2 revisions) (flutter/flutter#145784) 2024-03-26 [email protected] Roll Flutter Engine from cffd1dcfe6a5 to baede78d2352 (2 revisions) (flutter/flutter#145778) 2024-03-26 [email protected] Correct typo: "Free" to "Three" in comments (flutter/flutter#145689) 2024-03-26 [email protected] Fix disabled `DropdownMenu` doesn't defer the mouse cursor (flutter/flutter#145686) 2024-03-26 [email protected] Roll Flutter Engine from b2d93a64cbc7 to cffd1dcfe6a5 (9 revisions) (flutter/flutter#145773) 2024-03-26 [email protected] Roll Packages from 28d126c to ab1630b (1 revision) (flutter/flutter#145755) 2024-03-26 [email protected] Memory leaks clean up 2 (flutter/flutter#145757) 2024-03-26 [email protected] Fix memory leak in Overlay.wrap. (flutter/flutter#145744) 2024-03-26 [email protected] Be tolerant of backticks around directory name in `pub` output. (flutter/flutter#145768) 2024-03-26 [email protected] Fix `ExpansionTile` Expanded/Collapsed announcement is interrupted by VoiceOver (flutter/flutter#143936) ...

…lutter/flutter#145686)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 25, 2024

TahaTesser marked this pull request as ready for review March 25, 2024 14:20

TahaTesser requested review from HansMuller and QuncCccccc March 25, 2024 15:21

QuncCccccc approved these changes Mar 26, 2024

View reviewed changes

Fix disabled DropdownMenu doesn't defer the mouse cursor

34a001e

TahaTesser force-pushed the dropdownMenu_disabled_cursor branch from 8c923b6 to 34a001e Compare March 26, 2024 18:54

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2024

auto-submit bot merged commit d2c8552 into flutter:master Mar 26, 2024

TahaTesser deleted the dropdownMenu_disabled_cursor branch March 26, 2024 20:23

engine-flutter-autoroll mentioned this pull request Mar 27, 2024

Roll Flutter from dbdcead93225 to c881eee1d4dc (32 revisions) flutter/packages#6406

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

7ead037

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 27, 2024

Roll Flutter from dbdcead93225 to 4eab267b4050 (33 revisions) flutter/packages#6407

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

d491a50

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 27, 2024

Roll Flutter from dbdcead93225 to 6c0a4caa8ad6 (34 revisions) flutter/packages#6408

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

1594b83

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 27, 2024

Roll Flutter from dbdcead93225 to 4190b2ab7be7 (35 revisions) flutter/packages#6409

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

43a214d

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 27, 2024

Roll Flutter from dbdcead93225 to c6f9cdf1564d (36 revisions) flutter/packages#6410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

5cadf75

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Manual roll Flutter from dbdcead93225 to f5b65bad0f81 (41 revisions) flutter/packages#6418

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

2ee25cc

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to 1940955e89a3 (45 revisions) flutter/packages#6420

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

b03d9d2

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to 66d1872cd5cd (46 revisions) flutter/packages#6421

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

a24545b

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to ee5e6fac4c87 (47 revisions) flutter/packages#6423

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

fac6bed

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to 42988d1b0dd6 (48 revisions) flutter/packages#6424

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

9c71849

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to 0bcd228e678d (50 revisions) flutter/packages#6427

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

6da7972

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Roll Flutter from dbdcead93225 to 67271f69f7f8 (51 revisions) flutter/packages#6429

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

14401e2

…lutter/flutter#145686)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024

Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions) flutter/packages#6431

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

9be2e2f

…lutter/flutter#145686)

HansMuller mentioned this pull request Mar 29, 2024

Flutter Framework Team: Notable Commits #121415

Closed

TahaTesser mentioned this pull request Apr 2, 2024

Add DropdownMenu cursor behavior sample to DropdownMenu.enabled & DropdownMenu.requestFocusOnTap docs #146131

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

d2c8552 Fix disabled DropdownMenu doesn't defer the mouse cursor (f…

e9cc989

…lutter/flutter#145686)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix disabled `DropdownMenu` doesn't defer the mouse cursor #145686

Fix disabled `DropdownMenu` doesn't defer the mouse cursor #145686

Uh oh!

TahaTesser commented Mar 25, 2024 •

edited

Loading

Uh oh!

QuncCccccc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix disabled DropdownMenu doesn't defer the mouse cursor #145686

Fix disabled DropdownMenu doesn't defer the mouse cursor #145686

Uh oh!

Conversation

TahaTesser commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code sample

Preview

Pre-launch Checklist

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix disabled `DropdownMenu` doesn't defer the mouse cursor #145686

Fix disabled `DropdownMenu` doesn't defer the mouse cursor #145686

TahaTesser commented Mar 25, 2024 •

edited

Loading