Skip to content

Conversation

@eltociear
Copy link
Contributor

loosing -> losing

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loosing -> losing
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Mar 25, 2024
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lggtm.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 25, 2024

auto label is removed for flutter/flutter/145683, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2024
@auto-submit auto-submit bot merged commit 9fa731d into flutter:master Mar 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 26, 2024
Roll Flutter from 14774b9 to dbdcead (38 revisions)

flutter/flutter@14774b9...dbdcead

2024-03-25 [email protected] Roll Flutter Engine from ef896e942f44 to 04191a122e9a (1 revision) (flutter/flutter#145709)
2024-03-25 [email protected] Update semantics.dart (flutter/flutter#145683)
2024-03-25 [email protected] TwoDimensionalChildDelegate should dispatch creation and disposal events (flutter/flutter#145684)
2024-03-25 [email protected] Memory leaks clean up 1 (flutter/flutter#145691)
2024-03-25 [email protected] Roll Flutter Engine from 2e8d77dbb0f0 to ef896e942f44 (1 revision) (flutter/flutter#145705)
2024-03-25 [email protected] [Fix]: Searchbar doesn't lose focus when tapped outside (flutter/flutter#145232)
2024-03-25 [email protected] Fix typo in hitTest docs (flutter/flutter#145677)
2024-03-25 [email protected] Roll Packages from 611aea1 to 28d126c (1 revision) (flutter/flutter#145690)
2024-03-25 [email protected] [deps] Bump native assets dependencies (flutter/flutter#145612)
2024-03-25 [email protected] Roll Flutter Engine from 857584c458ff to 2e8d77dbb0f0 (1 revision) (flutter/flutter#145678)
2024-03-25 [email protected] Add `AnimationStyle` to `showBottomSheet` and `showModalBottomSheet` (flutter/flutter#145536)
2024-03-25 [email protected] Roll Flutter Engine from ae758d54630d to 857584c458ff (2 revisions) (flutter/flutter#145673)
2024-03-25 [email protected] Roll Flutter Engine from efdde39a2a57 to ae758d54630d (1 revision) (flutter/flutter#145669)
2024-03-25 [email protected] make hot reload reflect changes to asset transformer configurations (flutter/flutter#144660)
2024-03-25 [email protected] Roll Flutter Engine from 0734f47f2a3d to efdde39a2a57 (2 revisions) (flutter/flutter#145668)
2024-03-24 [email protected] Roll Flutter Engine from 7c139e0a4897 to 0734f47f2a3d (1 revision) (flutter/flutter#145662)
2024-03-24 [email protected] Leak clean up. (flutter/flutter#144803)
2024-03-24 [email protected] Turn off randomization for leak detection bots. (flutter/flutter#145624)
2024-03-24 [email protected] Roll Flutter Engine from 2f5afdf62365 to 7c139e0a4897 (1 revision) (flutter/flutter#145655)
2024-03-24 [email protected] Roll Flutter Engine from 7aa8521e640e to 2f5afdf62365 (2 revisions) (flutter/flutter#145651)
2024-03-23 [email protected] Roll Flutter Engine from 689ea4b10b17 to 7aa8521e640e (1 revision) (flutter/flutter#145643)
2024-03-23 [email protected] Roll Flutter Engine from 42d4262b4b20 to 689ea4b10b17 (1 revision) (flutter/flutter#145636)
2024-03-23 [email protected] Reland #128236 "Improve build output for all platforms" (flutter/flutter#145495)
2024-03-23 [email protected] Roll Flutter Engine from 7690eb12ded5 to 42d4262b4b20 (1 revision) (flutter/flutter#145635)
2024-03-23 [email protected] Roll Flutter Engine from 8a51e124fbf1 to 7690eb12ded5 (1 revision) (flutter/flutter#145634)
2024-03-23 [email protected] Roll Flutter Engine from bc4fa4367edb to 8a51e124fbf1 (4 revisions) (flutter/flutter#145630)
2024-03-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.8 to 3.24.9 (flutter/flutter#145627)
2024-03-23 [email protected] Add workaround for bug adding unicode strings to test reports. (flutter/flutter#145607)
2024-03-23 [email protected] Roll Flutter Engine from 52142e428760 to bc4fa4367edb (1 revision) (flutter/flutter#145626)
2024-03-23 [email protected] [web][docs] Improve HtmlElementView widget docs. (flutter/flutter#145192)
2024-03-23 [email protected] Disable flaky text_editing_integration tests temporarily. (flutter/flutter#145629)
2024-03-22 [email protected] Roll Flutter Engine from cc8f752b81e5 to 52142e428760 (4 revisions) (flutter/flutter#145625)
2024-03-22 [email protected] Fix skipping golden comparator for CI environments (flutter/flutter#145619)
2024-03-22 [email protected] Roll Flutter Engine from 68301f268278 to cc8f752b81e5 (1 revision) (flutter/flutter#145621)
2024-03-22 [email protected] Roll Packages from b7fbe68 to 611aea1 (4 revisions) (flutter/flutter#145615)
2024-03-22 [email protected] Roll Flutter Engine from 63ff0dedd8e6 to 68301f268278 (2 revisions) (flutter/flutter#145613)
2024-03-22 [email protected] Roll Flutter Engine from 09dadce76828 to 63ff0dedd8e6 (2 revisions) (flutter/flutter#145611)
2024-03-22 [email protected] 2DScrollView - Fix drag when one axis does not have enough content (flutter/flutter#145566)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants