InputDecorator M3 tests migration - Step7 - container #145583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
bleroux
force-pushed
the
M3_migration_input_decorator_container
branch
from
b8112d4 to
3c5bc6f
Compare
bleroux
force-pushed
the
M3_migration_input_decorator_container
branch
from
3c5bc6f to
a063a96
Compare
justinmc
approved these changes
Mar 28, 2024
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with some possible misnaming in the test titles to look at 👍 . Thanks for the pointer on which line numbers corresponded to the tests you added.
Sorry I forgot to send this review yesterday! I was scrambling to get predictive back into the release. Hopefully I didn't block you too much.
Contributor
There was a problem hiding this comment.
Did you mean "weight" instead of "height"?
Contributor
Author
There was a problem hiding this comment.
Oh good catch!
For the active indicator 'height' would be acceptable because it is a simple horizontal line (the M3 specification uses 'height' for this particular value). But for outlined text field, 'height' is misleading when applied to the rectangular outline (funny enough, the M3 specification uses 'width' in this case).
Using "weigth" looks like the best choice, thanks!
Contributor
There was a problem hiding this comment.
Here's another test where the title says "height" but you check the weight. It looks like there are others.
Contributor
There was a problem hiding this comment.
Is this one checking the painting style and not the color, as it says in the title?
Contributor
Author
There was a problem hiding this comment.
Another good catch, I duplicated this test from similar ones but in this case the container is not filled so the title should be updated. Thanks again!
bleroux
force-pushed
the
M3_migration_input_decorator_container
branch
from
a063a96 to
b08a823
Compare
bleroux
force-pushed
the
M3_migration_input_decorator_container
branch
from
b08a823 to
5e5a4e7
Compare
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 30, 2024
flutter/flutter@8528881...d12ba5c 2024-03-30 [email protected] Roll Flutter Engine from 08eb5ad6e498 to 3588d31a98f6 (1 revision) (flutter/flutter#146031) 2024-03-30 [email protected] Roll Flutter Engine from df581c316485 to 08eb5ad6e498 (2 revisions) (flutter/flutter#146028) 2024-03-30 [email protected] Roll Flutter Engine from 5df1042cd927 to df581c316485 (1 revision) (flutter/flutter#146025) 2024-03-30 [email protected] Roll Flutter Engine from dce6ce366c74 to 5df1042cd927 (2 revisions) (flutter/flutter#146024) 2024-03-30 [email protected] Roll Flutter Engine from 221b49ae4a82 to dce6ce366c74 (1 revision) (flutter/flutter#146023) 2024-03-30 [email protected] Roll Flutter Engine from 0a751669e722 to 221b49ae4a82 (1 revision) (flutter/flutter#146022) 2024-03-30 [email protected] Roll Flutter Engine from 8ec35b6d63ba to 0a751669e722 (2 revisions) (flutter/flutter#146020) 2024-03-29 [email protected] Roll Flutter Engine from 4b6836f8ef00 to 8ec35b6d63ba (3 revisions) (flutter/flutter#146014) 2024-03-29 [email protected] Roll Flutter Engine from 4c079a6ff502 to 4b6836f8ef00 (3 revisions) (flutter/flutter#146010) 2024-03-29 [email protected] Implementing switch expressions in `flutter_tools/` (flutter/flutter#145632) 2024-03-29 [email protected] Generate test metrics consistently. (flutter/flutter#145943) 2024-03-29 [email protected] Roll Flutter Engine from 32c9dab552f0 to 4c079a6ff502 (3 revisions) (flutter/flutter#146007) 2024-03-29 [email protected] Add flutter_goldens README (flutter/flutter#145278) 2024-03-29 [email protected] Remove state shared across tests (flutter/flutter#145281) 2024-03-29 [email protected] Roll Flutter Engine from 8480145cc39d to 32c9dab552f0 (1 revision) (flutter/flutter#146005) 2024-03-29 [email protected] InputDecorator M3 tests migration - Step7 - container (flutter/flutter#145583) 2024-03-29 [email protected] Roll Flutter Engine from 7176173ea303 to 8480145cc39d (3 revisions) (flutter/flutter#146001) 2024-03-29 [email protected] Roll Flutter Engine from b16c0f136cdd to 7176173ea303 (1 revision) (flutter/flutter#145994) 2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145997) 2024-03-29 [email protected] Roll Flutter Engine from 68aa9ba386e1 to b16c0f136cdd (10 revisions) (flutter/flutter#145990) 2024-03-29 [email protected] Roll Packages from 924c7e6 to 51faaa1 (8 revisions) (flutter/flutter#145986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs adds a test group for the input decorator container, this group is organised similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs.
It is step 7 for the M3 test migration for
InputDecorator.Step 1: #142981
Step 2: #143369
Step 3: #143520
Step 4: #144169
Step 5: #144932
Step 6: #145213
Related Issue
Related to #139076
@justinmc The diff is not very readable. The tests added by this PR are from line 298 to line 975. Other changes are due to moving some existing tests to this new 'container' group.