Skip to content

[flutter_tools] Enable WebAssembly compilation everywhere, remove feature flag #145562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 26, 2024
Merged

[flutter_tools] Enable WebAssembly compilation everywhere, remove feature flag #145562

auto-submit merged 3 commits into from
Mar 26, 2024

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Mar 21, 2024

No description provided.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 21, 2024
@kevmoo kevmoo added the fyi-web For the attention of Web platform team label Mar 21, 2024
@kevmoo kevmoo marked this pull request as draft March 21, 2024 20:41
yjbanov
yjbanov reviewed Mar 21, 2024
View reviewed changes
@kevmoo
Copy link
Contributor Author

kevmoo commented Mar 21, 2024

Holding off until Monday to make sure the test PR sticks

@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@kevmoo kevmoo changed the title Enable WebAssembly compilation everywhere, remove feature flag [flutter_tools] Enable WebAssembly compilation everywhere, remove feature flag Mar 21, 2024
@kevmoo kevmoo marked this pull request as ready for review March 25, 2024 21:12
eyebrowsoffire
eyebrowsoffire approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 25, 2024

auto label is removed for flutter/flutter/145562, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2024
@auto-submit auto-submit bot merged commit 388f321 into flutter:master Mar 26, 2024
@kevmoo kevmoo deleted the stable_wasm branch March 26, 2024 19:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
dd7b04f 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
757f92e 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
376c987 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
d2d74c3 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
5909458 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
351fd23 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
d3fb908 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
b84770d 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
e94c8d1 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
d3aed6f 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
52f8e51 
…move feature flag (flutter/flutter#145562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
b143339 
…move feature flag (flutter/flutter#145562)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
1cb04e5 
…move feature flag (flutter/flutter#145562)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
388f321 [flutter_tools] Enable WebAssembly compilation everywhere, re…
56eb53e 
…move feature flag (flutter/flutter#145562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov left review comments

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App fyi-web For the attention of Web platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevmoo @yjbanov @eyebrowsoffire