Skip to content

Reland #128236 "Improve build output for all platforms" #145376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 20, 2024
Merged

Reland #128236 "Improve build output for all platforms" #145376

auto-submit merged 4 commits into from
Mar 20, 2024

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Mar 19, 2024

Reland #128236, reverted in #143125 and #145261.

This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.

Original description

Improves the build output:

  1. Gives confirmation that the build succeeded, in green
  2. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
  3. Gives the size of the built executable (when the built executable is self contained)

apk, appbundle

image image

macos, ios, ipa

Build executables are self-contained and use a newly introduced OperatingSystemUtils.getDirectorySize.

image image image

windows, linux, and web

Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

image image image

Size reporting

When applicable, the printed size matches the OS reported size.

  • macOS
    image
  • Windows
    image
  • Linux
    image

Related issues

Part of #120127
Fixes #121401

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from loic-sharma March 19, 2024 05:53
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Mar 19, 2024
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2024
@auto-submit auto-submit bot merged commit 6b568f3 into flutter:master Mar 20, 2024
@guidezpl guidezpl deleted the build-output branch March 20, 2024 17:03
@loic-sharma loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 20, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 20, 2024

A reason for requesting a revert of flutter/flutter/145376 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 20, 2024
@loic-sharma
Copy link
Member

loic-sharma commented Mar 20, 2024

Reason for revert: It caused the following post-submit failures:

  1. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752928710548811665/+/u/run_run_release_test_windows/stdout
  2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752927564747697169/+/u/run_run_release_test_windows/stdout

@loic-sharma loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 20, 2024
auto-submit bot pushed a commit that referenced this pull request Mar 20, 2024
Revert "Reland #128236 "Improve build output for all platforms" (#145376
32b9537 
)"

This reverts commit 6b568f3.
@auto-submit auto-submit bot mentioned this pull request Mar 20, 2024
Merged
8 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 20, 2024
auto-submit bot added a commit that referenced this pull request Mar 20, 2024
@auto-submit
Reverts "Reland #128236 "Improve build output for all platforms" (#14…
a01eac7 
…5376)" (#145487)

Reverts: #145376
Initiated by: loic-sharma
Reason for reverting: It caused the following post-submit failures:

1. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752928710548811665/+/u/run_run_release_test_windows/stdout
2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752927564747697169/+/u/run_run_release_test_windows/stdout
Original PR Author: guidezpl

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Reland #128236, reverted in #143125 and #145261.

This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes #121401
guidezpl added a commit to guidezpl/flutter that referenced this pull request Mar 20, 2024
@guidezpl
Reland flutter#128236 "Improve build output for all platforms" (flutt…
fe3c2a9 
…er#145376)

Reland flutter#128236, reverted in flutter#143125 and flutter#145261.

This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of flutter#120127
Fixes flutter#121401
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
92c46cc 
…ter/flutter#145376)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
b32226b 
…ter/flutter#145376)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
17a30f0 
…ter/flutter#145376)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
08c28db 
…ter/flutter#145376)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
f4491e1 
…ter/flutter#145376)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 21, 2024
@engine-flutter-autoroll
Roll Flutter from b96c13d to 18340ea (26 revisions) (#6370)
611aea1 
flutter/flutter@b96c13d...18340ea

2024-03-21 [email protected] Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) (flutter/flutter#145551)
2024-03-21 [email protected] Roll Packages from 23e56af to b7fbe68 (3 revisions) (flutter/flutter#145547)
2024-03-21 [email protected] Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) (flutter/flutter#145334)
2024-03-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll pub packages (#145509)" (flutter/flutter#145550)
2024-03-21 [email protected] Roll pub packages (flutter/flutter#145509)
2024-03-21 [email protected] Roll Flutter Engine from 14b67475cf80 to 7cdb240c4a16 (1 revision) (flutter/flutter#145533)
2024-03-21 [email protected] Roll Flutter Engine from 6de3d9b6196a to 14b67475cf80 (1 revision) (flutter/flutter#145529)
2024-03-21 [email protected] Roll Flutter Engine from c0d3ac3178fa to 6de3d9b6196a (1 revision) (flutter/flutter#145520)
2024-03-21 [email protected] Roll Flutter Engine from 23dc0cacc4db to c0d3ac3178fa (1 revision) (flutter/flutter#145519)
2024-03-21 [email protected] Roll Flutter Engine from a73e01364de0 to 23dc0cacc4db (2 revisions) (flutter/flutter#145517)
2024-03-21 [email protected] Roll Flutter Engine from 45ed36c17bb7 to a73e01364de0 (1 revision) (flutter/flutter#145516)
2024-03-21 [email protected] Roll Flutter Engine from 34b304a27f73 to 45ed36c17bb7 (1 revision) (flutter/flutter#145513)
2024-03-21 [email protected] Roll Flutter Engine from 912c61f30512 to 34b304a27f73 (1 revision) (flutter/flutter#145511)
2024-03-21 [email protected] Roll Flutter Engine from 98cfd9213332 to 912c61f30512 (1 revision) (flutter/flutter#145504)
2024-03-21 [email protected] Roll pub packages (flutter/flutter#145476)
2024-03-20 [email protected] Roll Flutter Engine from fe6927c79dc3 to 98cfd9213332 (1 revision) (flutter/flutter#145498)
2024-03-20 [email protected] Roll Flutter Engine from d1fe8994dedf to fe6927c79dc3 (1 revision) (flutter/flutter#145493)
2024-03-20 [email protected] Add helper widget parameter to InputDecoration (flutter/flutter#145157)
2024-03-20 [email protected] Remove embedding v1 code in framework (flutter/flutter#144726)
2024-03-20 [email protected] Roll Flutter Engine from 1b52f57ca07c to d1fe8994dedf (8 revisions) (flutter/flutter#145491)
2024-03-20 [email protected] Roll Flutter Engine from f803f2adec54 to 1b52f57ca07c (1 revision) (flutter/flutter#145479)
2024-03-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland #128236 "Improve build output for all platforms" (#145376)" (flutter/flutter#145487)
2024-03-20 [email protected] Roll Flutter Engine from fc2b7a9076b4 to f803f2adec54 (1 revision) (flutter/flutter#145475)
2024-03-20 [email protected] Reland #128236 "Improve build output for all platforms" (flutter/flutter#145376)
2024-03-20 [email protected] Roll Packages from a2f4ce0 to 23e56af (5 revisions) (flutter/flutter#145470)
2024-03-20 [email protected] Roll Flutter Engine from 883adfe2ef61 to fc2b7a9076b4 (1 revision) (flutter/flutter#145469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
6b568f3 Reland #128236 "Improve build output for all platforms" (flut…
9003b54 
…ter/flutter#145376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not all builds output success message with directory and size

2 participants

@guidezpl @loic-sharma