Update tokens to v2.3.5 #145356
Merged
Update tokens to v2.3.5 #145356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
guidezpl
approved these changes
Mar 19, 2024
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Nice. Worth noting tokens is now using semantic versioning
Member
There was a problem hiding this comment.
curious what is still using v 0.206?
Contributor
Author
There was a problem hiding this comment.
Yeah, I think this is because my last commit change. I reverted the tokens in slider.json because there're a big change on Slider which might cause Scuba failures. I think probably we can create a separate PR for it:)
github-actions
bot
added
the
a: internationalization
github-actions
bot
removed
the
a: internationalization
QuncCccccc
force-pushed
the
update_tokens_to_v_235
branch
from
37906c5 to
efb5c5d
Compare
QuncCccccc
added
the
autosubmit
2 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 29, 2024
flutter/flutter@89ea492...8528881 2024-03-29 [email protected] Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 [email protected] Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 [email protected] Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 [email protected] Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 [email protected] Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 [email protected] Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 [email protected] Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 [email protected] `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 [email protected] Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 [email protected] Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 [email protected] Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 22, 2024
This PR is to * Update the Material Design tokens to 4.0.0 Since the last token update(#145356), only `Slider` tokens have been updated. The M3 `Slider` has significant visual changes, compared to the original M3 Slider, so a separate PR would be needed. I commented out `SliderTemplate` and added a TODO when we are ready to add new widgets again.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
This PR is to * Update the Material Design tokens to 4.0.0 Since the last token update(flutter#145356), only `Slider` tokens have been updated. The M3 `Slider` has significant visual changes, compared to the original M3 Slider, so a separate PR would be needed. I commented out `SliderTemplate` and added a TODO when we are ready to add new widgets again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md.com.progress-indicatortoken set was created and should be used instead.Fixes PopupMenu Material 3 tokens #128877. The default text style is updated toAdded TODOs for the label text style ofbodyLargenow:)PopupMenuButton. Will create a separate PR because this change breaks Google testing.Pre-launch Checklist
///).