Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Mar 18, 2024

This manually rolls pub packages and updates some calls to use updated APIs that use Uri instead of file paths (since macro-generated sources don't exist as files on disk).

This manually rolls pub packages and updates a test for a signature change in the base adapter class.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2024
@DanTup DanTup marked this pull request as ready for review March 18, 2024 20:21
@DanTup DanTup mentioned this pull request Mar 18, 2024
@DanTup
Copy link
Contributor Author

DanTup commented Mar 18, 2024

@christopherfujino if you're happy with this, feel free to merge / add autosubmit :-)

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eyebrowsoffire
Copy link
Contributor

(@christopherfujino is out at a conference right now, so I'll go ahead and merge)

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2024
@auto-submit auto-submit bot merged commit 89ef73e into flutter:master Mar 18, 2024
@DanTup
Copy link
Contributor Author

DanTup commented Mar 19, 2024

Thanks!

@DanTup DanTup deleted the roll-packages branch March 19, 2024 07:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 19, 2024
flutter/flutter@f217fc1...d31a85b

2024-03-19 [email protected] Roll Flutter Engine from 4cec701f4635 to d8fbcfbd799c (1 revision) (flutter/flutter#145390)
2024-03-19 [email protected] Roll Flutter Engine from c9fbe6bab899 to 4cec701f4635 (1 revision) (flutter/flutter#145386)
2024-03-19 [email protected] Roll Flutter Engine from de6b8f49b849 to c9fbe6bab899 (2 revisions) (flutter/flutter#145383)
2024-03-19 [email protected] Activate shortcuts based on NumLock state (flutter/flutter#145146)
2024-03-19 [email protected] Roll Flutter Engine from 59519ceee30a to de6b8f49b849 (1 revision) (flutter/flutter#145381)
2024-03-19 [email protected] Roll Flutter Engine from ac8f1f233d6f to 59519ceee30a (2 revisions) (flutter/flutter#145379)
2024-03-19 [email protected] Roll Flutter Engine from 4a86b5b17c39 to ac8f1f233d6f (3 revisions) (flutter/flutter#145375)
2024-03-19 [email protected] Roll Flutter Engine from c0d1b0d5d43f to 4a86b5b17c39 (1 revision) (flutter/flutter#145373)
2024-03-19 [email protected] Roll Flutter Engine from 3d909f14118e to c0d1b0d5d43f (1 revision) (flutter/flutter#145371)
2024-03-19 [email protected] Roll Flutter Engine from 0ee413ee276a to 3d909f14118e (5 revisions) (flutter/flutter#145370)
2024-03-18 [email protected] Roll Flutter Engine from 89df726bf13a to 0ee413ee276a (3 revisions) (flutter/flutter#145365)
2024-03-18 [email protected] Roll Flutter Engine from 3fde3678a357 to 89df726bf13a (1 revision) (flutter/flutter#145359)
2024-03-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.7 to 3.24.8 (flutter/flutter#145358)
2024-03-18 [email protected] Roll pub packages + update DAP tests (flutter/flutter#145349)
2024-03-18 [email protected] Fix for issue 140372 (flutter/flutter#144947)
2024-03-18 [email protected] Introduce methods for computing the baseline location of a RenderBox without affecting the current layout (flutter/flutter#144655)
2024-03-18 [email protected] Roll Flutter Engine from 016206de75bc to 3fde3678a357 (2 revisions) (flutter/flutter#145350)
2024-03-18 [email protected] Roll Flutter Engine from 90c4d64d410f to 016206de75bc (2 revisions) (flutter/flutter#145345)
2024-03-18 [email protected] Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit (flutter/flutter#145343)
2024-03-18 [email protected] Roll Flutter Engine from 9162c8309e24 to 90c4d64d410f (1 revision) (flutter/flutter#145342)
2024-03-18 [email protected] Add --no-dds to Mac_arm64_ios version of hot_mode_dev_cycle_ios__benchmark (flutter/flutter#145335)
2024-03-18 [email protected] Roll Flutter Engine from 89fb886a162c to 9162c8309e24 (2 revisions) (flutter/flutter#145336)
2024-03-18 [email protected] Roll Flutter Engine from 86de0f75606f to 89fb886a162c (1 revision) (flutter/flutter#145327)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants