Skip to content

Conversation

@passsy
Copy link
Contributor

@passsy passsy commented Mar 18, 2024

WidgetsApp.debugShowWidgetInspectorOverride was replaced with WidgetsBinding.instance.debugShowWidgetInspectorOverrideNotifier in #144029.

The old API was removed, not deprecated.

It is used by some open-source projects, thus I'm making the effort of bringing the API back as deprecated.

Fixes #145333

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 18, 2024
@goderbauer
Copy link
Member

cc @polina-c @jacob314

@polina-c
Copy link
Contributor

Thank you!!!

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024
@auto-submit auto-submit bot merged commit 4bbe6d5 into flutter:master Mar 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 21, 2024
flutter/flutter@b96c13d...18340ea

2024-03-21 [email protected] Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) (flutter/flutter#145551)
2024-03-21 [email protected] Roll Packages from 23e56af to b7fbe68 (3 revisions) (flutter/flutter#145547)
2024-03-21 [email protected] Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) (flutter/flutter#145334)
2024-03-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll pub packages (#145509)" (flutter/flutter#145550)
2024-03-21 [email protected] Roll pub packages (flutter/flutter#145509)
2024-03-21 [email protected] Roll Flutter Engine from 14b67475cf80 to 7cdb240c4a16 (1 revision) (flutter/flutter#145533)
2024-03-21 [email protected] Roll Flutter Engine from 6de3d9b6196a to 14b67475cf80 (1 revision) (flutter/flutter#145529)
2024-03-21 [email protected] Roll Flutter Engine from c0d3ac3178fa to 6de3d9b6196a (1 revision) (flutter/flutter#145520)
2024-03-21 [email protected] Roll Flutter Engine from 23dc0cacc4db to c0d3ac3178fa (1 revision) (flutter/flutter#145519)
2024-03-21 [email protected] Roll Flutter Engine from a73e01364de0 to 23dc0cacc4db (2 revisions) (flutter/flutter#145517)
2024-03-21 [email protected] Roll Flutter Engine from 45ed36c17bb7 to a73e01364de0 (1 revision) (flutter/flutter#145516)
2024-03-21 [email protected] Roll Flutter Engine from 34b304a27f73 to 45ed36c17bb7 (1 revision) (flutter/flutter#145513)
2024-03-21 [email protected] Roll Flutter Engine from 912c61f30512 to 34b304a27f73 (1 revision) (flutter/flutter#145511)
2024-03-21 [email protected] Roll Flutter Engine from 98cfd9213332 to 912c61f30512 (1 revision) (flutter/flutter#145504)
2024-03-21 [email protected] Roll pub packages (flutter/flutter#145476)
2024-03-20 [email protected] Roll Flutter Engine from fe6927c79dc3 to 98cfd9213332 (1 revision) (flutter/flutter#145498)
2024-03-20 [email protected] Roll Flutter Engine from d1fe8994dedf to fe6927c79dc3 (1 revision) (flutter/flutter#145493)
2024-03-20 [email protected] Add helper widget parameter to InputDecoration (flutter/flutter#145157)
2024-03-20 [email protected] Remove embedding v1 code in framework (flutter/flutter#144726)
2024-03-20 [email protected] Roll Flutter Engine from 1b52f57ca07c to d1fe8994dedf (8 revisions) (flutter/flutter#145491)
2024-03-20 [email protected] Roll Flutter Engine from f803f2adec54 to 1b52f57ca07c (1 revision) (flutter/flutter#145479)
2024-03-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland #128236 "Improve build output for all platforms" (#145376)" (flutter/flutter#145487)
2024-03-20 [email protected] Roll Flutter Engine from fc2b7a9076b4 to f803f2adec54 (1 revision) (flutter/flutter#145475)
2024-03-20 [email protected] Reland #128236 "Improve build output for all platforms" (flutter/flutter#145376)
2024-03-20 [email protected] Roll Packages from a2f4ce0 to 23e56af (5 revisions) (flutter/flutter#145470)
2024-03-20 [email protected] Roll Flutter Engine from 883adfe2ef61 to fc2b7a9076b4 (1 revision) (flutter/flutter#145469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WidgetsApp.debugShowWidgetInspectorOverride was removed

4 participants