InputDecorator M3 tests migration - Step6 - constraints #145213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #145213 at sha ea39767fc4a2016087ebf69620c9b9927aed4f61 |
justinmc
approved these changes
Mar 15, 2024
Contributor
There was a problem hiding this comment.
Could this pumpAndSettle just be pump or does it not work? And same for below.
Contributor
Author
There was a problem hiding this comment.
Yes they can be replaced, good catch. 👍
I introduced kTransitionDuration and replaced those pumpAndSettle with pump(kTransitionDuration).
bleroux
force-pushed
the
M3_tests_migration_input_decorator_constraints
branch
from
ea39767 to
bd2f95d
Compare
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 18, 2024
flutter/flutter@7c860dd...f217fc1 2024-03-18 [email protected] Roll Packages from 756dcc1 to a757073 (3 revisions) (flutter/flutter#145325) 2024-03-18 [email protected] Roll Flutter Engine from f11015e14d24 to 86de0f75606f (1 revision) (flutter/flutter#145322) 2024-03-18 [email protected] InputDecorator M3 tests migration - Step6 - constraints (flutter/flutter#145213) 2024-03-18 [email protected] Update `inherited_theme_test.dart`, `ink_paint_test.dart`, `ink_splash_test.dart`, `opacity_test.dart` for Material 3 (flutter/flutter#144013) 2024-03-18 [email protected] Roll Flutter Engine from eac9db75f902 to f11015e14d24 (2 revisions) (flutter/flutter#145321) 2024-03-18 [email protected] Roll Flutter Engine from aebc0021cd18 to eac9db75f902 (1 revision) (flutter/flutter#145308) 2024-03-18 [email protected] Roll Flutter Engine from 89c775963926 to aebc0021cd18 (1 revision) (flutter/flutter#145305) 2024-03-18 [email protected] Roll Flutter Engine from 5c31faa15ab7 to 89c775963926 (1 revision) (flutter/flutter#145303) 2024-03-17 [email protected] Roll Flutter Engine from 4c420dd2dfd9 to 5c31faa15ab7 (2 revisions) (flutter/flutter#145294) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
## Description This PRs adds a test group for the input decorator container, this group is organised similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs. It is step 7 for the M3 test migration for `InputDecorator`. Step 1: #142981 Step 2: #143369 Step 3: #143520 Step 4: #144169 Step 5: #144932 Step 6: #145213 ## Related Issue Related to #139076 @justinmc The diff is not very readable. The tests added by this PR are from line 298 to line 975. Other changes are due to moving some existing tests to this new 'container' group.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
InputDecorator.constraintsrelated tests to M3 and also various regression tests.It is the sixth step for the M3 test migration for
InputDecorator.Step 1: #142981
Step 2: #143369
Step 3: #143520
Step 4: #144169
Step 5: #144932
Related Issue
Related to #139076
@justinmc A somewhat small PR, I wanted to migrate the small group related to 'InputDecoration.constraints' (starting at line 2801), it adds a test checking min interactive height and two others that shows one way to bypass the standard min interactive height.