Skip to content

Conversation

@vashworth
Copy link
Contributor

Original PR: #144022

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17.

Fixes flutter#144020.
@vashworth vashworth marked this pull request as ready for review March 14, 2024 21:12
@vashworth vashworth changed the title Run tests on iOS 17 exclusively (#144022) [CP] Run tests on iOS 17 exclusively (#144022) Mar 14, 2024
@XilaiZhang XilaiZhang requested review from jmagman and keyonghan March 14, 2024 23:44
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang
Copy link
Contributor

Sorry I missed this cherry pick and didn't realize it isn't merged. This might have to go in through next week's hotfix.

@itsjustkevin I filed #145557 to see if we can let PR authors merge the PRs

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2024
@auto-submit auto-submit bot merged commit f1f4106 into flutter:flutter-3.19-candidate.1 Mar 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
ditman pushed a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2024
danielatego pushed a commit to danielatego/flutter that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants