Skip to content

Roll pub packages #145167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flutter-pub-roller-bot wants to merge 1 commit into from
Closed

Roll pub packages #145167

flutter-pub-roller-bot wants to merge 1 commit into from

Conversation

@flutter-pub-roller-bot
Copy link
Contributor

@flutter-pub-roller-bot flutter-pub-roller-bot commented Mar 14, 2024

This PR was generated by flutter update-packages --force-upgrade.

@flutter-pub-roller-bot flutter-pub-roller-bot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Mar 14, 2024
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 14, 2024
@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2024

@loic-sharma Looks like the auto roller is now able to roll intl to 0.19.0. Let's see if this goes through.

@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 14, 2024

FYI @eliasyishak

@loic-sharma
Copy link
Member

loic-sharma commented Mar 14, 2024

Fixes #139861

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 14, 2024

auto label is removed for flutter/flutter/145167, due to - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2024

Looks like the new intl version is changing some localized number formatting:

00:06 +191: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_localizations/test/material/translations_test.dart: spot check selectedRowCount translations                                             
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: 'បាន​ជ្រើស​រើស​ធាតុ 10.000'
  Actual: 'បាន​ជ្រើស​រើស​ធាតុ 10,000'
   Which: is different.
          Expected: ... ើស​ធាតុ 10.000
            Actual: ... ើស​ធាតុ 10,000
                                  ^
           Differ at offset 21

When the exception was thrown, this was the stack:
#4      main.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_localizations/test/material/translations_test.dart:177:5)
<asynchronous suspension>

This was caught by the test expectation on the following line:
  file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_localizations/test/material/translations_test.dart line 177
The test description was:
  spot check selectedRowCount translations
════════════════════════════════════════════════════════════════════════════════════════════════════

00:06 +191 -1: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_localizations/test/material/translations_test.dart: spot check selectedRowCount translations [E]                                      
  Test failed. See exception logs above.
  The test description was: spot check selectedRowCount translations
  
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test (but after the test had completed):
Expected: 'បាន​ជ្រើស​រើស​ធាតុ 10.000'
  Actual: 'បាន​ជ្រើស​រើស​ធាតុ 10,000'
   Which: is different.
          Expected: ... ើស​ធាតុ 10.000
            Actual: ... ើស​ធាតុ 10,000
                                  ^
           Differ at offset 21

When the exception was thrown, this was the stack:
#0      fail (package:matcher/src/expect/expect.dart:149:31)
#1      _expect (package:matcher/src/expect/expect.dart:144:3)
#2      expect (package:matcher/src/expect/expect.dart:56:3)
#3      expect (package:flutter_test/src/widget_tester.dart:474:18)
#4      main.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_localizations/test/material/translations_test.dart:177:5)
<asynchronous suspension>
════════════════════════════════════════════════════════════════════════════════════════════════════
  Test failed. See exception logs above.
  The test description was: spot check selectedRowCount translations

@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2024

@mosuem do you happen to know if that's expected and correct?

@loic-sharma
Copy link
Member

loic-sharma commented Mar 14, 2024 •
edited
Loading

@goderbauer and I did some research:

  1. Wikipedia article indicates Khmer uses commas as the thousands separator: https://en.wikipedia.org/wiki/Khmer_numerals#Numbers_from_100_to_10,000,000
  2. Google Translate uses commas as the thousands separator: https://translate.google.com/?sl=en&tl=km&text=I%20have%201%2C000%20apples&op=translate
  3. Gemini agrees it should be a comma: The Khmer language uses a comma (,) as its thousands separator. However, you might also see spaces used as a thousands separator, especially in less formal contexts.

I'll do a manual roll that also updates the test: #145170

Once that lands, I'll close this so the autoroller can resume.

@loic-sharma loic-sharma mentioned this pull request Mar 14, 2024
Merged
9 tasks
@mosuem
Copy link
Contributor

mosuem commented Mar 14, 2024

Just FYI: The authority here is the Unicode CLDR data, which agrees on the grouping separator being a comma.

@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2024

Awesome. Thanks for confirming and the additional context.

@ditman
Copy link
Member

ditman commented Mar 14, 2024

This is where the separators flipped:

https://unicode.org/cldr/charts/44/delta/km.html

(I must have read an ICU PR the wrong way around!)

auto-submit bot pushed a commit that referenced this pull request Mar 15, 2024
@loic-sharma
Roll pub packages manually (#145170)
8d54abf 
The automated roll failed as a test needs to be updated: #145167

Fixes: #139861
@goderbauer
Copy link
Member

goderbauer commented Mar 15, 2024

Closing this since #145170 landed so the roller can pick it up from there again.

@goderbauer goderbauer closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@flutter-pub-roller-bot @goderbauer @christopherfujino @loic-sharma @mosuem @ditman @fluttergithubbot