Skip to content

Update proxied devices to handle connection interface and diagnostics. #145061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 13, 2024
Merged

Update proxied devices to handle connection interface and diagnostics. #145061

auto-submit merged 1 commit into from
Mar 13, 2024

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Mar 13, 2024

Also improve the performance of daemon device discovery by parallelizing the calls.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chingjun
Update proxied devices to handle connection interface and diagnostics.
2a23d72 
Also improve the performance of daemon device discovery by parallelizing
the calls.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 13, 2024
christopherfujino
christopherfujino reviewed Mar 13, 2024
View reviewed changes
packages/flutter_tools/lib/src/commands/daemon.dart
for (final PollingDeviceDiscovery discoverer in _discoverers)
for (final Device device in await discoverer.discoverDevices())
await _deviceToMap(device),
discoverer.discoverDevices(timeout: timeout),
Copy link
Contributor

@christopherfujino christopherfujino Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel there's a non-trivial chance this leads to some weird state error in the future--but I also have no way to verify this, so let's ship it and see.

Copy link
Contributor Author

@chingjun chingjun Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, if we are seeing some weird issue in the future, the most likely cause is some race conditions that we should fix anyway.

Btw, did you forget to approve this PR, or are you intending to take another look? :)

christopherfujino
christopherfujino approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024
@auto-submit auto-submit bot merged commit 3dba3f2 into flutter:master Mar 13, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
a5bcebd 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
0460ee7 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
142a7e5 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
ad92360 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
228b90c 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
34f52d7 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
d2d1909 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
38432c4 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
4b446a4 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
c3d4e9d 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
cf7ea99 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
f37f4c9 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
d06c1fa 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
c4b7ba5 
…gnostics. (flutter/flutter#145061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
197aa88 
…gnostics. (flutter/flutter#145061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
9246c14 
…gnostics. (flutter/flutter#145061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
5fbb9fe 
…gnostics. (flutter/flutter#145061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
3dba3f2 Update proxied devices to handle connection interface and dia…
5599c3f 
…gnostics. (flutter/flutter#145061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingjun @christopherfujino