Skip to content

Reland "Add a microbenchmark for text intrinsic height layout (#145007)" #145037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 13, 2024
Merged

Reland "Add a microbenchmark for text intrinsic height layout (#145007)" #145037

auto-submit merged 2 commits into from
Mar 13, 2024

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Mar 12, 2024 •
edited
Loading

Add the missing Directionality widget and await test.pump() call: commit: 0fd7712

Without the pump 1s, it sometimes schedules multiple handleBeginFrames and handleDrawFrames.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Mar 12, 2024
@LongCatIsLooong LongCatIsLooong changed the title Reland 145007 Reland "Add a microbenchmark for text intrinsic height layout (#145007)" Mar 12, 2024
goderbauer
goderbauer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2024

auto label is removed for flutter/flutter/145037, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 13, 2024

auto label is removed for flutter/flutter/145037, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024
@auto-submit auto-submit bot merged commit 8270872 into flutter:master Mar 13, 2024
@LongCatIsLooong LongCatIsLooong deleted the reland-145007 branch March 13, 2024 00:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
7368d40 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
fbf3f44 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
807b4a8 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
3987961 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
98c5791 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
f5a2e57 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
912b58c 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
e0c3622 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
d047c1c 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
bbbf176 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
f602613 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
c4f37e6 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
e374f84 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
dddd561 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
392133b 
… (#145007)" (flutter/flutter#145037)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
35908d6 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
25819e5 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
bfd171d 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
a94df43 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
3b04423 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
1732029 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
3c8b492 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
591cced 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
0cac254 
… (#145007)" (flutter/flutter#145037)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
8270872 Reland "Add a microbenchmark for text intrinsic height layout…
16fdf7c 
… (#145007)" (flutter/flutter#145037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @goderbauer