Skip to content

Update gold validator to check for regression in flutter-gold check #145008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 12, 2024
Merged

Update gold validator to check for regression in flutter-gold check #145008

auto-submit merged 1 commit into from
Mar 12, 2024

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 12, 2024 •
edited
Loading

There were some recent change in flutter/cocoon. Check that the bot warns and holds up the PR as expected.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 12, 2024
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 12, 2024

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #145008 at sha 122a1e6

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 12, 2024
@Piinks Piinks requested a review from goderbauer March 12, 2024 19:29
@Piinks
Copy link
Contributor Author

Piinks commented Mar 12, 2024

I'd like to land this to confirm it is processed correctly and passes post submit.

goderbauer
goderbauer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Update gold validator to check for regression in flutter-gold check
542d63f 
There were some recent change in flutter/cocoon. Check that the bot warns and holds up the PR as expected.
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2024

auto label is removed for flutter/flutter/145008, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot merged commit eb74e5a into master Mar 12, 2024
@auto-submit auto-submit bot deleted the Piinks-patch-2 branch March 12, 2024 20:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
e99a789 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
ae60c88 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
c1c45e9 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
9ec33f2 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
c6f5ee3 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
278267c 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
8791ede 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
79eb146 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
f888ffa 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
991e6ca 
… check (flutter/flutter#145008)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
6433749 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
9140566 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
e75c3b0 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
ba9c340 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
01335f0 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
740750e 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
a69d0ea 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
f6aa4ac 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
ba954a9 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
739068f 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
bbe96ed 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
386228f 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
c393b96 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
4b4943b 
… check (flutter/flutter#145008)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
eb74e5a Update gold validator to check for regression in flutter-gold…
4814116 
… check (flutter/flutter#145008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @goderbauer