Skip to content

Add a microbenchmark for text intrinsic height layout #145007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 12, 2024
Merged

Add a microbenchmark for text intrinsic height layout #145007

auto-submit merged 2 commits into from
Mar 12, 2024

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Mar 12, 2024 •
edited
Loading

For #144577. There's no promise that the performance will be great when IntrinsicHeight/IntrinsicWidth is used extensively but it's not that uncommon of a widget.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Mar 12, 2024
goderbauer
goderbauer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2024

auto label is removed for flutter/flutter/145007, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot merged commit e992023 into flutter:master Mar 12, 2024
@LongCatIsLooong LongCatIsLooong deleted the text-intrinsic-height-bench branch March 12, 2024 20:41
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Mar 12, 2024 •
edited
Loading

Reason for revert: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20microbenchmarks/15561/overview

@LongCatIsLooong LongCatIsLooong added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 12, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2024

A reason for requesting a revert of flutter/flutter/145007 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 12, 2024
@LongCatIsLooong LongCatIsLooong added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 12, 2024
auto-submit bot pushed a commit that referenced this pull request Mar 12, 2024
Revert "Add a microbenchmark for text intrinsic height layout (#145007)"
55424ae 
This reverts commit e992023.
@auto-submit auto-submit bot mentioned this pull request Mar 12, 2024
Merged
9 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 12, 2024
auto-submit bot added a commit that referenced this pull request Mar 12, 2024
@auto-submit
Reverts "Add a microbenchmark for text intrinsic height layout (#145007…
03dfebd 
…)" (#145029)

Reverts: #145007
Initiated by: LongCatIsLooong
Reason for reverting: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20microbenchmarks/15561/overview
Original PR Author: LongCatIsLooong

Reviewed By: {goderbauer}

This change reverts the following previous change:
For #144577. There's no promise that the performance will be great when `IntrinsicHeight/IntrinsicWidth` is used extensively but it's not that uncommon of a widget.
LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Mar 12, 2024
@LongCatIsLooong
Reland "Add a microbenchmark for text intrinsic height layout (flutte…
4634379 
…r#145007)"

This reverts commit 03dfebd.
auto-submit bot pushed a commit that referenced this pull request Mar 13, 2024
@LongCatIsLooong
Reland "Add a microbenchmark for text intrinsic height layout (#145007)…
8270872 
…" (#145037)

Add the missing `Directionality` widget and `await test.pump()` call: commit: 0fd7712

Without the `pump` 1s, it sometimes schedules multiple `handleBeginFrame`s and `handleDrawFrame`s.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
d6d7e5e 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
a91ff11 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
283af7b 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
aefe3e5 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
e7ec30c 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
53595e5 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
4af7bc8 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
6e36d6a 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
cfdd098 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
3dadfcf 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
fae6666 
…r/flutter#145007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
809d9d5 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
c45617a 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
4c2c57f 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
d39ed11 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
5d224a3 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
c31218a 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
fda40a3 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
33d54b1 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
10a9ced 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
d7a7a23 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
59a9c55 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
b2f72af 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
124bbb5 
…r/flutter#145007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
e992023 Add a microbenchmark for text intrinsic height layout (flutte…
0c34554 
…r/flutter#145007)
@jmagman jmagman mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @goderbauer